Uh oh!
There was an error while loading. Please reload this page.
explain why CTFE/Miri perform truncation on shift offset - #91162
Merged
Conversation
rust-highfive
commented
Nov 23, 2021
Contributor
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
commented
Nov 23, 2021
Contributor
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
oli-obk
commented
Nov 23, 2021
Contributor
Please also throw a comment on the mir binop stating that this op masks the rhs. |
oli-obk
commented
Nov 24, 2021
Contributor
@bors r+ |
bors
commented
Nov 24, 2021
Collaborator
📌 Commit 5f6ccf6 has been approved by |
oli-obk
commented
Nov 24, 2021
Contributor
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 24, 2021
…li-obk explain why CTFE/Miri perform truncation on shift offset Closesrust-lang/miri#1920
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…li-obk explain why CTFE/Miri perform truncation on shift offset Closesrust-lang/miri#1920
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…li-obk explain why CTFE/Miri perform truncation on shift offset Closesrust-lang/miri#1920
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#89359 (Various fixes for const_trait_impl) - rust-lang#90499 (Link with default MACOSX_DEPLOYMENT_TARGET if not otherwise specified.) - rust-lang#91096 (Print associated types on opaque `impl Trait` types) - rust-lang#91111 (Do not visit attributes in `ItemLowerer`.) - rust-lang#91162 (explain why CTFE/Miri perform truncation on shift offset) - rust-lang#91185 (Remove `-Z force-overflow-checks`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closesrust-lang/miri#1920