Skip to content

rustdoc: use slice::contains instead of open-coding it - #89444

Merged
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/contains-str
Oct 4, 2021
Merged

rustdoc: use slice::contains instead of open-coding it#89444
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/contains-str

Conversation

@notriddle

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2021
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

r=me once CI pass.

@rust-log-analyzer

This comment has been minimized.

@notriddle
notriddleforce-pushed the notriddle/contains-str branch from 78743c1 to dd02a38CompareOctober 1, 2021 20:16
@rust-log-analyzer

This comment has been minimized.

@notriddle
notriddleforce-pushed the notriddle/contains-str branch from dd02a38 to 55bb0afCompareOctober 1, 2021 20:58
Comment threadsrc/librustdoc/passes/html_tags.rs Outdated
@notriddlenotriddle changed the title rustdoc: use Itertools::contains instead of open-coding itrustdoc: use slice::contains instead of open-coding itOct 1, 2021
@notriddle
notriddleforce-pushed the notriddle/contains-str branch from 55bb0af to 277a018CompareOctober 1, 2021 23:42
@notriddle

Copy link
Copy Markdown
ContributorAuthor

Sorry about that. I probably should've noticed that slice::contains existed.

@jyn514

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 2, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 277a018 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2021
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 3, 2021
…=jyn514
rustdoc: use slice::contains instead of open-coding it
@ManishearthManishearth mentioned this pull request Oct 3, 2021
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 4, 2021
…=jyn514
rustdoc: use slice::contains instead of open-coding it
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 4, 2021
…=jyn514
rustdoc: use slice::contains instead of open-coding it
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2021
…ingjubilee
Rollup of 13 pull requests
Successful merges:
- rust-lang#83655 ([aarch64] add target feature outline-atomics)
- rust-lang#87091 (implement advance_(back_)_by on more iterators)
- rust-lang#88451 (Fix an ICE caused by type mismatch errors being ignored)
- rust-lang#88452 (VecDeque: improve performance for From<[T; N]>)
- rust-lang#89400 (Improve wording of `map_or_else` docs)
- rust-lang#89407 (Recommend running `cargo clean` in E0514 output)
- rust-lang#89443 (Include the length in BTree hashes)
- rust-lang#89444 (rustdoc: use slice::contains instead of open-coding it)
- rust-lang#89447 (Improve error message for missing angle brackets in `[_]::method`)
- rust-lang#89453 (Consistently use 'supertrait'.)
- rust-lang#89483 (Practice diagnostic message convention)
- rust-lang#89500 (Fix ICE with buffered lint referring to AST node deleted by everybody_loops)
- rust-lang#89508 (Stabilize `const_panic`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b115a16 into rust-lang:masterOct 4, 2021
@rustbotrustbot added this to the 1.57.0 milestone Oct 4, 2021
@notriddle
notriddle deleted the notriddle/contains-str branch October 4, 2021 23:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@notriddle@rust-highfive@GuillaumeGomez@rust-log-analyzer@jyn514@bors@cuviper@rustbot