Uh oh!
There was an error while loading. Please reload this page.
Consistently use 'supertrait'. - #89453
Merged
Merged
Conversation
rust-highfive
commented
Oct 2, 2021
Contributor
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
A subset of places referred to 'super-trait', so this changes them to all use 'supertrait'. This matches 'supertype' and some other usages. An exception is 'auto-trait' which is consistently used in that manner.
waywardmonkeysforce-pushed
the
consistent-supertrait-usage
branch
from
October 2, 2021 01:06
e39c62b to
058a21dComparenagisa
commented
Oct 2, 2021
Member
There are a ton of prior art of "super" and especially "sub" being combined into a single word (cf. subset, superset, subtext, supernormal...) so this seems… right? There are a fair number of uses of |
waywardmonkeys
commented
Oct 2, 2021
ContributorAuthor
The reference also defines it as I also looked at which usage had more steam in this repo and it was the |
nagisa
commented
Oct 2, 2021
Member
@bors r+ rollup |
bors
commented
Oct 2, 2021
Collaborator
📌 Commit 058a21d has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 3, 2021
…t-usage, r=nagisa Consistently use 'supertrait'. A subset of places referred to 'super-trait', so this changes them to all use 'supertrait'. This matches 'supertype' and some other usages. An exception is 'auto-trait' which is consistently used in that manner.
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 4, 2021
…t-usage, r=nagisa Consistently use 'supertrait'. A subset of places referred to 'super-trait', so this changes them to all use 'supertrait'. This matches 'supertype' and some other usages. An exception is 'auto-trait' which is consistently used in that manner.
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 4, 2021
…t-usage, r=nagisa Consistently use 'supertrait'. A subset of places referred to 'super-trait', so this changes them to all use 'supertrait'. This matches 'supertype' and some other usages. An exception is 'auto-trait' which is consistently used in that manner.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2021
…ingjubilee Rollup of 13 pull requests Successful merges: - rust-lang#83655 ([aarch64] add target feature outline-atomics) - rust-lang#87091 (implement advance_(back_)_by on more iterators) - rust-lang#88451 (Fix an ICE caused by type mismatch errors being ignored) - rust-lang#88452 (VecDeque: improve performance for From<[T; N]>) - rust-lang#89400 (Improve wording of `map_or_else` docs) - rust-lang#89407 (Recommend running `cargo clean` in E0514 output) - rust-lang#89443 (Include the length in BTree hashes) - rust-lang#89444 (rustdoc: use slice::contains instead of open-coding it) - rust-lang#89447 (Improve error message for missing angle brackets in `[_]::method`) - rust-lang#89453 (Consistently use 'supertrait'.) - rust-lang#89483 (Practice diagnostic message convention) - rust-lang#89500 (Fix ICE with buffered lint referring to AST node deleted by everybody_loops) - rust-lang#89508 (Stabilize `const_panic`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A subset of places referred to 'super-trait', so this changes them
to all use 'supertrait'. This matches 'supertype' and some other
usages. An exception is 'auto-trait' which is consistently used
in that manner.