Uh oh!
There was an error while loading. Please reload this page.
rustc_span: Ident::invalid -> Ident::empty - #89990
Merged
Merged
Conversation
The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s.
rust-highfive
commented
Oct 17, 2021
Contributor
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
commented
Oct 17, 2021
Contributor
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
wesleywiser
approved these changes
Oct 17, 2021
wesleywiser
commented
Oct 17, 2021
Member
@bors r+ roll up |
bors
commented
Oct 17, 2021
Collaborator
📌 Commit a680833 has been approved by |
wesleywiser
commented
Oct 17, 2021
Member
@bors rollup |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 17, 2021
rustc_span: `Ident::invalid` -> `Ident::empty` The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s as well.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 17, 2021
rustc_span: `Ident::invalid` -> `Ident::empty` The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s as well.
This was referenced Oct 17, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2021
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89950 (bootstrap: tweak verbosity settings) - rust-lang#89965 (Fix ICE with `let...else` and `ref mut`) - rust-lang#89974 (Nicer error message if the user attempts to do let...else if) - rust-lang#89987 (Check implementing type for `#[doc(hidden)]`) - rust-lang#89989 (rustdoc: Add static size assertion for `clean::Type`) - rust-lang#89990 (rustc_span: `Ident::invalid` -> `Ident::empty`) - rust-lang#89993 (Remove dead code from `compiletest::json`) - rust-lang#89996 (Bump backtrace) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 21, 2021
rustc_span: `Ident::invalid` -> `Ident::empty` The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The equivalent for
Symbols was renamed some time ago (kw::Invalid->kw::Empty), and it makes sense to do the same thing forIdents as well.