Skip to content

Rollup of 6 pull requests - #89992

Closed
matthiaskrgr wants to merge 12 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-wjbpitp
Closed

Rollup of 6 pull requests#89992
matthiaskrgr wants to merge 12 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-wjbpitp

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Aaron1011and others added 12 commits August 14, 2021 19:49
The affected crates have had plenty of time to update.
By keeping these as lints rather than making them hard errors,
we ensure that downstream crates will still be able to compile,
even if they transitive depend on broken versions of the affected
crates.
This should hopefully discourage anyone from writing any
new code which relies on the backwards-compatibility behavior.
The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s.
…esleywiser
Make all proc-macro back-compat lints deny-by-default
The affected crates have had plenty of time to update.
By keeping these as lints rather than making them hard errors,
we ensure that downstream crates will still be able to compile,
even if they transitive depend on broken versions of the affected
crates.
This should hopefully discourage anyone from writing any
new code which relies on the backwards-compatibility behavior.
resolve: Use `NameBinding` for local variables and generic parameters
`NameBinding` is a structure used for representing any name introduction (an item, or import, or even a built-in).
Except that local variables and generic parameters weren't represented as `NameBinding`s, for this reason they requires separate paths in name resolution code in several places.
This PR introduces `NameBinding`s for local variables as well and simplifies all the code working with them leaving only the `NameBinding` paths.
…-mut, r=petrochenkov
Fix ICE with `let...else` and `ref mut`
Fixesrust-lang#89960, opened for review.
I'm not satisfied with the current diagnostics, any ideas?
Nicer error message if the user attempts to do let...else if
Gives a nice "conditional `else if` is not supported for `let...else`" error when encountering a `let...else if` pattern, as suggested in the [let...else tracking issue](rust-lang#87335 (comment)).
…c, r=GuillaumeGomez
Check implementing type for `#[doc(hidden)]`
Closesrust-lang#85526.
rustc_span: `Ident::invalid` -> `Ident::empty`
The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s as well.
@rustbotrustbot added the rollup A PR which is a rollup label Oct 17, 2021
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=6 rollup=never

@bors

bors commented Oct 17, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 5ce733a has been approved by matthiaskrgr

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 17, 2021
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

Running x.py test locally gives an error
tidy error: /home/matthias/vcs/github/rust/compiler/rustc_resolve/src/lib.rs: too many lines (3043) (add // ignore-tidy-filelength to the file to suppress this error)

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job mingw-check failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.channel := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions := True
configure: dist.missing-tools := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: configure: run `python /checkout/x.py --help`
configure: ---
* highest error code: E0785
Found 501 error codes
Found 0 error codes with no tests
Done!
tidy error: /checkout/compiler/rustc_resolve/src/lib.rs: too many lines (3043) (add `// ignore-tidy-filelength` to the file to suppress this error)
some tidy checks failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build" "16"
Build completed unsuccessfully in 0:00:12

@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r-
😓

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 17, 2021
@matthiaskrgr
matthiaskrgr deleted the rollup-wjbpitp branch November 20, 2021 15:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@matthiaskrgr@bors@rust-log-analyzer@rustbot@Aaron1011@petrochenkov@JohnTitor@est31@pierwill