Skip to content

Make thiscall abi on unsupported platforms a hard error - #90241

Merged
bors merged 1 commit into
rust-lang:masterfrom
beepster4096:thiscall_lint_upgrade
Oct 26, 2021
Merged

Make thiscall abi on unsupported platforms a hard error#90241
bors merged 1 commit into
rust-lang:masterfrom
beepster4096:thiscall_lint_upgrade

Conversation

@beepster4096

Copy link
Copy Markdown
Contributor

As suggested in #42202 (comment), this PR makes use of the thiscall abi on unsupported a hard error instead of a lint.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2021
@rust-log-analyzer

This comment has been minimized.

@petrochenkov

Copy link
Copy Markdown
Contributor

r? @petrochenkov

@rust-log-analyzer

This comment has been minimized.

@petrochenkov

petrochenkov commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

The is_like_windows flag is irrelevant to supporting ABI in codegen (it's a compatibility hack), Thiscall should be supported if self.arch == "x86" and not supported otherwise.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2021
@rust-log-analyzer

This comment has been minimized.

@petrochenkovpetrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2021
@petrochenkov

Copy link
Copy Markdown
Contributor

r=me after squashing commits.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2021
@beepster4096

Copy link
Copy Markdown
ContributorAuthor

Commits have been squashed.

@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit a46daf0 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2021
…askrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#90181 (fix(rustc_typeck): report function argument errors on matching type)
- rust-lang#90241 (Make thiscall abi on unsupported platforms a hard error)
- rust-lang#90294 (Update books)
- rust-lang#90295 (Update cargo)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit fc8df9b into rust-lang:masterOct 26, 2021
@rustbotrustbot added this to the 1.58.0 milestone Oct 26, 2021
@bors

bors commented Oct 26, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a46daf0 with merge 1b61b1b...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@beepster4096@rust-highfive@rust-log-analyzer@petrochenkov@bors@oli-obk@rustbot