Uh oh!
There was an error while loading. Please reload this page.
fix(rustc_typeck): report function argument errors on matching type - #90181
Merged
Conversation
rust-highfive
commented
Oct 22, 2021
Contributor
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
notriddle
marked this pull request as draft
October 23, 2021 01:36
notriddleforce-pushed
the
notriddle/error-pointer
branch
from
October 24, 2021 00:35
79324d5 to
7c37697Comparenotriddle
marked this pull request as ready for review
October 24, 2021 01:25
notriddle
commented
Oct 24, 2021
ContributorAuthor
r? @estebank |
notriddle
commented
Oct 24, 2021
ContributorAuthor
CC @nagisa Not sure how to assign to both of you? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
estebank
commented
Oct 24, 2021
Contributor
r=me after squashing |
bors
commented
Oct 25, 2021
Collaborator
☔ The latest upstream changes (presumably #90249) made this pull request unmergeable. Please resolve the merge conflicts. |
notriddleforce-pushed
the
notriddle/error-pointer
branch
from
October 25, 2021 19:24
7c37697 to
8520105Compareestebank
commented
Oct 25, 2021
Contributor
@bors r+ |
bors
commented
Oct 25, 2021
Collaborator
📌 Commit 8520105 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2021
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#90181 (fix(rustc_typeck): report function argument errors on matching type) - rust-lang#90241 (Make thiscall abi on unsupported platforms a hard error) - rust-lang#90294 (Update books) - rust-lang#90295 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
commented
Oct 26, 2021
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2021
… r=JohnTitor Add regression test for issue 90164 Closesrust-lang#90164 (previously fixed by rust-lang#90181)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2021
… r=JohnTitor Add regression test for issue 90164 Closesrust-lang#90164 (previously fixed by rust-lang#90181)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#90101