Uh oh!
There was an error while loading. Please reload this page.
Rollup of 4 pull requests - #90249
Merged
Merged
Conversation
… crate Partly address rust-lang#78543 by making the error quieter. We don't have access to the `typeck` tables from foreign crates, so we used to completely skip the new code when checking foreign crates. Now, we carry on and don't provide as nice output (we don't clarify *what* is making the `Future: !Send`), but at least we no longer emit a sea of derived obligations in the output. [1]: https://blog.rust-lang.org/inside-rust/2019/10/11/AsyncAwait-Not-Send-Error-Improvements.html
Both style-check and date-check are now on the 2021 edition, and this commit also updates their repositories' submodules.
…n-future, r=tmandry Use the "nice E0277 errors"[1] for `!Send` `impl Future` from foreign crate Partly address rust-lang#78543 by making the error quieter. We don't have access to the `typeck` tables from foreign crates, so we used to completely skip the new code when checking foreign crates. Now, we carry on and don't provide as nice output (we don't clarify *what* is making the `Future: !Send`), but at least we no longer emit a sea of derived obligations in the output. [1]: https://blog.rust-lang.org/inside-rust/2019/10/11/AsyncAwait-Not-Send-Error-Improvements.html r? `@tmandry`
Do not mention a reexported item if it's private Fixesrust-lang#90113 The _actual_ regression was introduced in rust-lang#73652, then rust-lang#88838 made it worse. This fixes the issue by not counting such an import as a candidate.
…Simulacrum tidy: Remove submodules from edition exception list Both style-check and date-check are now on the 2021 edition, and this PR also updates their repositories' submodules. cc rust-lang/rustc-dev-guide#1238 cc rust-lang/reference#1099 cc rust-lang#89103 (comment)
…k-Simulacrum Add alias for guillaume.gomez@huawei.com Hopefully it'll stop making me appear twice in the thanks page. :)
matthiaskrgr
commented
Oct 25, 2021
MemberAuthor
@bors r+ rollup=never p=4 |
bors
commented
Oct 25, 2021
Collaborator
📌 Commit 34dcfd3 has been approved by |
bors
commented
Oct 25, 2021
Collaborator
bors
commented
Oct 25, 2021
Collaborator
☀️ Test successful - checks-actions |
This was referenced Oct 25, 2021
rust-timer
commented
Oct 25, 2021
Collaborator
Finished benchmarking commit (32f3887): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
!Sendimpl Futurefrom foreign crate #89889 (Use the "nice E0277 errors"[1] for!Sendimpl Futurefrom foreign crate)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup