Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #90458
Closed
matthiaskrgr wants to merge 10 commits into
Closed
Conversation
Also, remove the highlighting of the search bar in disabled state. This reduces flicker when loading a page.
…omez rustdoc: remove flicker during page load The search bar has a `:disabled` style that makes it grey, which creates a distracting flicker from grey to white when the page finishes loading. The search bar should stay the same color throughout page load. A blank white search bar might create an incorrect impression for users with JS turned off. Since they can't use the search functionality, I've hidden the search bar in noscript.css. Fixesrust-lang#90246 r? `@GuillaumeGomez` Demo: https://rustdoc.crud.net/jsha/flashy-searchbar/std/string/struct.String.html
…n514 Fix rare ICE during typeck in rustdoc scrape_examples While testing the `--scrape-examples` extension on the [wasmtime](https://github.com/bytecodealliance/wasmtime) repository, I found some additional edge cases. Specifically, when asking to typecheck a body containing a function call, I would sometimes get an ICE if: * The body doesn't exist * The function's HIR node didn't have a type This adds checks for both of those conditions. (Also this updates a test to check that the sources of a reverse-dependency are correctly generated and linked.) r? `@jyn514`
…amelid Document `doc(keyword)` unstable attribute r? `@camelid`
Remove `rustc_hir::hir_id::HirIdVec` See rust-lang#90408 (comment): > IIRC, `HirIdVec` is never used, you can delete it. PR rust-lang#72015 has been abandoned. r? `@cjgillot`
Remove unnecessary `Option` from `promote_candidate` return type
matthiaskrgr
commented
Oct 31, 2021
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Oct 31, 2021
Collaborator
📌 Commit 68cab5c has been approved by |
bors
commented
Oct 31, 2021
Collaborator
⌛ Testing commit 68cab5c with merge 0b40339c2612928974c5ccf411a67476e49853fc... |
emilyalbini
commented
Nov 1, 2021
Member
rust-log-analyzer
commented
Nov 1, 2021
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
doc(keyword)unstable attribute #90398 (Documentdoc(keyword)unstable attribute)rustc_hir::hir_id::HirIdVec#90450 (Removerustc_hir::hir_id::HirIdVec)Optionfrompromote_candidatereturn type #90452 (Remove unnecessaryOptionfrompromote_candidatereturn type)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup