Skip to content

Implement TryFrom<&'_ mut [T]> for [T; N] - #91086

Merged
bors merged 4 commits into
rust-lang:masterfrom
rhysd:issue-91085
Dec 13, 2021
Merged

Implement TryFrom<&'_ mut [T]> for [T; N]#91086
bors merged 4 commits into
rust-lang:masterfrom
rhysd:issue-91085

Conversation

@rhysd

@rhysdrhysd commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

Fixes#91085.

@rust-highfive

rust-highfive commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rhysd
rhysdforce-pushed the issue-91085 branch 2 times, most recently from 9afb451 to b50245cCompareNovember 20, 2021 13:05
@rhysd
rhysd marked this pull request as ready for review November 20, 2021 14:17
@rhysd

rhysd commented Nov 20, 2021

Copy link
Copy Markdown
ContributorAuthor

I confirmed ./x.py test ./library/core passed on my machine (macOS 11.6.1).

jyn514
jyn514 suggested changes Nov 20, 2021
View reviewed changes
Comment threadlibrary/core/src/array/mod.rs Outdated
@jyn514jyn514 added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-libs-api [DEPRECATED; DO NOT USE] labels Nov 20, 2021
@rhysd@jyn514
Update version in stable attribute
66e0523
Co-authored-by: Joshua Nelson <github@jyn.dev>
camelid
camelid reviewed Nov 20, 2021
View reviewed changes
Comment threadlibrary/core/src/array/mod.rs Outdated
@Mark-Simulacrum

Mark-Simulacrum commented Nov 20, 2021

Copy link
Copy Markdown
Member

r? rust-lang/libs-api for the fcp

@dtolnay

dtolnay commented Nov 21, 2021

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented Nov 21, 2021•
edited by m-ou-se
Loading

Copy link
Copy Markdown

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 21, 2021
@rhysd@camelid
Reborrow mut slice instead of converting it with as_ref
ac083c6
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
@inquisitivecrystalinquisitivecrystal added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 21, 2021
@rhysd

rhysd commented Dec 2, 2021

Copy link
Copy Markdown
ContributorAuthor

@jyn514 Would you review this PR again? I applied all suggestions and I believe it's ready for merge.

@jyn514

jyn514 commented Dec 2, 2021

Copy link
Copy Markdown
Member

@rhysd it needs to wait for the FCP to finish first (so at least one more T-libs member needs to approve, and them the final comment period lasts 10 days).

@rhysd

rhysd commented Dec 2, 2021

Copy link
Copy Markdown
ContributorAuthor

@jyn514 I got it. I misunderstood that the approval needs to be done before finishing FCP.

@rfcbotrfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Dec 2, 2021
@rfcbotrfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 2, 2021
@rfcbot

rfcbot commented Dec 2, 2021

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

camelid
camelid reviewed Dec 3, 2021
View reviewed changes
Comment threadlibrary/core/tests/array.rs
m-ou-se
m-ou-se reviewed Dec 4, 2021
View reviewed changes
Comment threadlibrary/core/src/array/mod.rs Outdated
@rfcbotrfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 12, 2021
@rfcbot

rfcbot commented Dec 12, 2021

Copy link
Copy Markdown

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@m-ou-se

m-ou-se commented Dec 12, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Dec 12, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 16711fe has been approved by m-ou-se

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 12, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2021
@bors
Auto merge ofrust-lang#91841- matthiaskrgr:rollup-zlhsg5a, r=matthi…
f7fd79a
…askrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#91086 (Implement `TryFrom<&'_ mut [T]>` for `[T; N]`)
- rust-lang#91091 (Stabilize `ControlFlow::{is_break, is_continue}`)
- rust-lang#91749 (BTree: improve public descriptions and comments)
- rust-lang#91819 (rustbot: Add autolabeling for `T-compiler`)
- rust-lang#91824 (Make `(*mut T)::write_bytes` `const`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 42f8d48 into rust-lang:masterDec 13, 2021
@rustbotrustbot added this to the 1.59.0 milestone Dec 13, 2021
@apirainoapiraino removed the to-announce Announce this issue on triage meeting label Dec 16, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-ou-sem-ou-sem-ou-se left review comments
@camelidcamelidcamelid left review comments
+1 more reviewer
@jyn514jyn514jyn514 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dtolnaydtolnay

Labels

disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.needs-fcpThis change is insta-stable, or significant enough to need a team FCP to proceed.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

&[T] can be converted into [T; N] but &mut [T] can't

13 participants

@rhysd@rust-highfive@rust-log-analyzer@Mark-Simulacrum@dtolnay@rfcbot@jyn514@m-ou-se@bors@camelid@apiraino@inquisitivecrystal@rustbot