Skip to content

Stabilize ControlFlow::{is_break, is_continue} - #91091

Merged
bors merged 1 commit into
rust-lang:masterfrom
ecstatic-morse:control-flow-enum-is
Dec 13, 2021
Merged

Stabilize ControlFlow::{is_break, is_continue}#91091
bors merged 1 commit into
rust-lang:masterfrom
ecstatic-morse:control-flow-enum-is

Conversation

@ecstatic-morse

@ecstatic-morseecstatic-morse commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

The type itself was stabilized in 1.55, but using it is not ergonomic without these helper functions. Stabilize them.

r? rust-lang/libs-api

@rust-highfive

rust-highfive commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2021
@inquisitivecrystal

inquisitivecrystal commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

Random extremely minor comment: control_flow_enum_is feels a bit weird to read as a feature name. I'm expecting to find something else after the "is". I understand the reasoning, and at the end of the day it's not like users are going to need to turn on a stabilized feature, but it still seems a bit suboptimal.

@inquisitivecrystalinquisitivecrystal added A-control-flow Area: Control flow needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api [DEPRECATED; DO NOT USE] labels Nov 20, 2021
@scottmcmscottmcm added the I-libs-api-nominated [DEPRECATED; DO NOT USE] label Nov 22, 2021
@dtolnaydtolnay removed the I-libs-api-nominated [DEPRECATED; DO NOT USE] label Nov 26, 2021
@dtolnay

dtolnay commented Nov 26, 2021

Copy link
Copy Markdown
Member

@rust-lang/libs-api:
@rfcbot fcp merge

impl<B,C>ControlFlow<B,C>{pubfnis_break(&self) -> bool;pubfnis_continue(&self) -> bool;}

The ControlFlow type has been stable since #85608:

pubenumControlFlow<B,C = ()>{Continue(C),Break(B),}

@rfcbot

rfcbot commented Nov 26, 2021•
edited by BurntSushi
Loading

Copy link
Copy Markdown

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 26, 2021
@rfcbot

rfcbot commented Dec 2, 2021

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbotrfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 12, 2021
@rfcbot

rfcbot commented Dec 12, 2021

Copy link
Copy Markdown

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@m-ou-se

m-ou-se commented Dec 12, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Dec 12, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 7ba4acc has been approved by m-ou-se

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
@camelid

camelid commented Dec 12, 2021

Copy link
Copy Markdown
Member

@bors rollup

@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 12, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2021
@bors
Auto merge ofrust-lang#91841- matthiaskrgr:rollup-zlhsg5a, r=matthi…
f7fd79a
…askrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#91086 (Implement `TryFrom<&'_ mut [T]>` for `[T; N]`)
- rust-lang#91091 (Stabilize `ControlFlow::{is_break, is_continue}`)
- rust-lang#91749 (BTree: improve public descriptions and comments)
- rust-lang#91819 (rustbot: Add autolabeling for `T-compiler`)
- rust-lang#91824 (Make `(*mut T)::write_bytes` `const`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6227d42 into rust-lang:masterDec 13, 2021
@rustbotrustbot added this to the 1.59.0 milestone Dec 13, 2021
@apirainoapiraino removed the to-announce Announce this issue on triage meeting label Dec 16, 2021
@hellow554hellow554 mentioned this pull request Feb 23, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 24, 2022
@matthiaskrgr
Rollup merge ofrust-lang#94283- hellow554:stable_flow_control, r=Dy…
f3433d1
…lan-DPC
remove feature gate in control_flow examples
Stabilization was done in rust-lang#91091, but the two examples weren't updated accordingly.
Probably too late to put it into stable, but it should be in the next release :)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dtolnaydtolnay

Labels

A-control-flowArea: Control flowdisposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.needs-fcpThis change is insta-stable, or significant enough to need a team FCP to proceed.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

11 participants

@ecstatic-morse@rust-highfive@inquisitivecrystal@dtolnay@rfcbot@m-ou-se@bors@camelid@apiraino@scottmcm@rustbot