Uh oh!
There was an error while loading. Please reload this page.
Improve unsafe diagnostic - #91133
Merged
Merged
Conversation
rust-highfive
commented
Nov 22, 2021
Contributor
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
terrarier2111force-pushed
the
unsafe-diagnostic
branch
from
November 23, 2021 15:42
a5ccc7b to
b244b5cCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
terrarier2111
commented
Nov 24, 2021
ContributorAuthor
r? @estebank |
terrarier2111force-pushed
the
unsafe-diagnostic
branch
5 times, most recently
from
November 27, 2021 10:23
f5a26dc to
8078071Compare
This comment has been minimized.
This comment has been minimized.
terrarier2111force-pushed
the
unsafe-diagnostic
branch
3 times, most recently
from
November 27, 2021 13:01
bdd4cae to
1075035Compare
This comment has been minimized.
This comment has been minimized.
terrarier2111force-pushed
the
unsafe-diagnostic
branch
2 times, most recently
from
November 27, 2021 13:48
fa2fceb to
f3d2cecCompareterrarier2111force-pushed
the
unsafe-diagnostic
branch
from
November 27, 2021 13:57
ec2ec39 to
3a13a72Compareterrarier2111
commented
Dec 8, 2021
ContributorAuthor
@estebank could you take a look at this? |
It would be amazing for this to get a review. |
jackh726
commented
Mar 12, 2022
Member
Sorry for the delay here! @bos r+ |
ghost
commented
Mar 17, 2022
Is there something holding this from being merged ? I'll fix it. |
jackh726
commented
Mar 17, 2022
Member
Bors? @bors r+ |
bors
commented
Mar 17, 2022
Collaborator
📌 Commit 3a13a72 has been approved by |
bors
commented
Mar 17, 2022
Collaborator
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
jackh726
commented
Mar 17, 2022
Member
r? @jackh726 |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#91133 (Improve `unsafe` diagnostic) - rust-lang#93222 (Make ErrorReported impossible to construct outside `rustc_errors`) - rust-lang#93745 (Stabilize ADX target feature) - rust-lang#94309 ([generator_interior] Be more precise with scopes of borrowed places) - rust-lang#94698 (Remove redundant code from copy-suggestions) - rust-lang#94731 (Suggest adding `{ .. }` around a const function call with arguments) - rust-lang#94960 (Fix many spelling mistakes) - rust-lang#94982 (Add deprecated_safe feature gate and attribute, cc rust-lang#94978) - rust-lang#94997 (debuginfo: Fix ICE when generating name for type that produces a layout error.) - rust-lang#95000 (Fixed wrong type name in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes: #90880
I didn't use the exact proposed messages though.