erase late-bound regions in dyn projection types for debuginfo by compiler-errors · Pull Request #95020 · rust-lang/rust

compiler-errors · 2022-03-16T18:55:08Z

simply skipping the binder leaves late-bound regions that will cause debug assertions to fail when checking the layout of the projection ty, so let's erase the regions instead.

sorry for taking so long to put this up, had trouble getting rustc set up on a new computer.

fixes#94998

rust-highfive · 2022-03-16T18:56:02Z

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

compiler-errors · 2022-03-16T19:01:00Z

cc: @jackh726, @michaelwoerister, or @lqd if one of yall care to review this since y'all were involved in #94998 and related issues.

matthiaskrgr · 2022-03-16T19:03:14Z

Could this fix some of the older tickets as well, or are these "different" bugs?
https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+value.has_escaping_bound_vars

compiler-errors · 2022-03-16T19:09:32Z

@matthiaskrgr probably not, since I think this is not a generalized fix, and each of these is likely due to a unique mishandling of Binder.

#92537 and #92271 might be related/fixed by this one, though, since it has to do with debuginfo, though I am unable to test them because I don't have a windows machine.

jackh726 · 2022-03-16T19:32:53Z

@bors delegate+ p=1

r=me on this. Not sure if @michaelwoerister has any additional thoughts for e.g. debug symbol names for the test. Let's make sure this hits nightly either way; seems to be getting hit a lot and we can also add more thorough tests.

bors · 2022-03-16T19:32:55Z

✌️ @compiler-errors can now approve this pull request

compiler-errors · 2022-03-16T20:01:34Z

CI is passing and Jack had a good point to get it into tonight's nightly, so I will land this now. @michaelwoerister please let me know if I should do any follow-up fixes.

@bors r=jackh726

bors · 2022-03-16T20:01:35Z

📌 Commit b69b3d0 has been approved by jackh726

bors · 2022-03-16T20:01:36Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

compiler-errors · 2022-03-16T20:04:26Z

Hiya @Dylan-DPC! The tree is closed due to #94997 which is another debuginfo fix, right? Can I p=100 this to make sure it lands on the next nightly, or do we expect the tree to open soon?

edit: Oh, tree is closed due to infra issues. nvm!

ehuss · 2022-03-17T02:39:47Z

@bors treeclosed-

bors · 2022-03-17T02:40:00Z

⌛ Testing commit b69b3d0 with merge 7142f4c41789d00f4e890aab871942853b93540d...

bors · 2022-03-17T02:54:55Z

💔 Test failed - checks-actions

ehuss · 2022-03-17T02:57:45Z

@bors treeclosed=100

ehuss · 2022-03-17T02:58:20Z

@bors r=jackh726

bors · 2022-03-17T02:58:22Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Implement -Z oom=panic #88098

bors · 2022-03-17T02:58:22Z

📌 Commit b69b3d0 has been approved by jackh726

bors · 2022-03-17T02:58:23Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

RalfJung · 2022-03-17T18:30:56Z

https://www.githubstatus.com/ is green again so let's see if we can re-open the tree...
@bors treeclosed-

bors · 2022-03-17T18:31:03Z

⌛ Testing commit b69b3d0 with merge 91f598a88570d1cf2f2f86876065a2a6f8d184ba...

compiler-errors · 2022-03-17T18:33:15Z

@RalfJung: this will probably fail again until @ehuss is done investigating issues with the ppc64-linux target in #95046. I don't think bors was failing just because of github issues. See the zulip thread.

bors · 2022-03-17T18:48:10Z

💔 Test failed - checks-actions

Dylan-DPC · 2022-03-17T18:52:09Z

@bors treeclosed=100

jackh726 · 2022-03-17T18:52:48Z

@bors retry

RalfJung · 2022-03-17T19:04:58Z

Oh, sorry -- the timing made it look like this was due to the GH issues...

bors · 2022-03-17T21:54:28Z

⌛ Testing commit b69b3d0 with merge 4ca56d2...

bors · 2022-03-18T00:35:10Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 4ca56d2 to master...

rust-timer · 2022-03-18T02:01:42Z

Finished benchmarking commit (4ca56d2): comparison url.

Summary: This benchmark run did not return any relevant results. 3 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rust-highfive assigned estebank Mar 16, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 16, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2022

erase late-bound regions in dyn projection types for debuginfo
b69b3d0

compiler-errors force-pushed the late-debuginfo branch from 03aea55 to b69b3d0Compare March 16, 2022 18:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2022

This was referenced Mar 17, 2022
Improve unsafe diagnostic #91133
Merged
[generator_interior] Be more precise with scopes of borrowed places #94309
Merged
Suggest adding { .. } around a const function call with arguments #94731
Merged
update Miri #95048
Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2022

This was referenced Mar 17, 2022
Make negative coherence work when there's impl negative on super predicates #95039
Merged
Refactor: remove an unnecessary pattern for ignoring all parts #95047
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2022

bors merged commit 4ca56d2 into rust-lang:masterMar 18, 2022

rustbot added this to the 1.61.0 milestone Mar 18, 2022

compiler-errors mentioned this pull request Mar 18, 2022
ICE: Compiling minimal Bevy snippet on nightly: assertion failed: !value.has_escaping_bound_vars() #95060
Closed

TaKO8Ki mentioned this pull request Mar 18, 2022
ICE when compiling rocket = { version = "0.5.0-rc.1", features = ["tls"] } on Mac with nightly #95070
Closed

Alexendoo mentioned this pull request Mar 19, 2022
dioxus hello world example causes compiler panic on windows #92537
Closed

compiler-errors mentioned this pull request Apr 3, 2022
ICE on nightly-2022-03-18 when compilation ordinary Rust project. #95623
Closed

compiler-errors deleted the late-debuginfo branch April 7, 2022 04:30

aosemp mentioned this pull request Apr 24, 2022
rust compile crash at wirefilter #96354
Closed

Uh oh!

Uh oh!

Conversation

compiler-errors commented Mar 16, 2022

Uh oh!

rust-highfive commented Mar 16, 2022

Uh oh!

compiler-errors commented Mar 16, 2022

Uh oh!

matthiaskrgr commented Mar 16, 2022

Uh oh!

compiler-errors commented Mar 16, 2022

Uh oh!

jackh726 commented Mar 16, 2022

Uh oh!

bors commented Mar 16, 2022

Uh oh!

compiler-errors commented Mar 16, 2022

Uh oh!

bors commented Mar 16, 2022

Uh oh!

bors commented Mar 16, 2022

Uh oh!

compiler-errors commented Mar 16, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ehuss commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

ehuss commented Mar 17, 2022

Uh oh!

ehuss commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

RalfJung commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

compiler-errors commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

Dylan-DPC commented Mar 17, 2022

Uh oh!

jackh726 commented Mar 17, 2022

Uh oh!

RalfJung commented Mar 17, 2022

Uh oh!

bors commented Mar 17, 2022

Uh oh!

bors commented Mar 18, 2022

Uh oh!

rust-timer commented Mar 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

compiler-errors commented Mar 16, 2022•
edited
Loading