Skip to content

Add missing whitespace before disabled HTML attribute - #91630

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:missing-whitespace
Dec 8, 2021
Merged

Add missing whitespace before disabled HTML attribute#91630
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:missing-whitespace

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

On the w3c HTML checker, with the current generated HTML we get:

Screenshot from 2021-12-07 15-10-38

The problem was that we were telling tera to remove too many whitespace.

r? @notriddle

@GuillaumeGomezGuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Dec 7, 2021
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

@bors: r=notriddle rollup

@bors

bors commented Dec 7, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 4dd3f4e has been approved by notriddle

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 7, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
…r=notriddle
Add missing whitespace before disabled HTML attribute
On the [w3c HTML checker](https://validator.w3.org/nu/#textarea), with the current generated HTML we get:
![Screenshot from 2021-12-07 15-10-38](https://user-images.githubusercontent.com/3050060/145044653-b38fb679-da76-4890-853f-b696d8fdc06e.png)
The problem was that we were telling tera to remove too many whitespace.
r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
…r=notriddle
Add missing whitespace before disabled HTML attribute
On the [w3c HTML checker](https://validator.w3.org/nu/#textarea), with the current generated HTML we get:
![Screenshot from 2021-12-07 15-10-38](https://user-images.githubusercontent.com/3050060/145044653-b38fb679-da76-4890-853f-b696d8fdc06e.png)
The problem was that we were telling tera to remove too many whitespace.
r? ``@notriddle``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
…r=notriddle
Add missing whitespace before disabled HTML attribute
On the [w3c HTML checker](https://validator.w3.org/nu/#textarea), with the current generated HTML we get:
![Screenshot from 2021-12-07 15-10-38](https://user-images.githubusercontent.com/3050060/145044653-b38fb679-da76-4890-853f-b696d8fdc06e.png)
The problem was that we were telling tera to remove too many whitespace.
r? ```@notriddle```
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2021
…askrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#90709 (Only shown relevant type params in E0283 label)
- rust-lang#91551 (Allow for failure of subst_normalize_erasing_regions in const_eval)
- rust-lang#91570 (Evaluate inline const pat early and report error if too generic)
- rust-lang#91571 (Remove unneeded access to pretty printer's `s` field in favor of deref)
- rust-lang#91610 (Link to rustdoc_json_types docs instead of rustdoc-json RFC)
- rust-lang#91619 (Update cargo)
- rust-lang#91630 (Add missing whitespace before disabled HTML attribute)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 382426b into rust-lang:masterDec 8, 2021
@rustbotrustbot added this to the 1.59.0 milestone Dec 8, 2021
@GuillaumeGomez
GuillaumeGomez deleted the missing-whitespace branch December 8, 2021 21:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-uiArea: Rustdoc UI (generated HTML)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@bors@notriddle@rustbot