Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #91665
Merged
Merged
Conversation
When we point at a binding to suggest giving it a type, erase all the type for ADTs that have been resolved, leaving only the ones that could not be inferred. For small shallow types this is not a problem, but for big nested types with lots of params, this can otherwise cause a lot of unnecessary visual output.
When the value of a const param isn't inferred, replace it with the param name from the definition.
…=nagisa Only shown relevant type params in E0283 label When we point at a binding to suggest giving it a type, erase all the type for ADTs that have been resolved, leaving only the ones that could not be inferred. For small shallow types this is not a problem, but for big nested types with lots of params, this can otherwise cause a lot of unnecessary visual output.
…e, r=oli-obk Allow for failure of subst_normalize_erasing_regions in const_eval Fixesrust-lang#72845 Using associated types that cannot be normalized previously resulted in an ICE. We now allow for normalization failure and return a "TooGeneric" error in that case. r? ```@RalfJung``` maybe?
Evaluate inline const pat early and report error if too generic Fixrust-lang#90150 ````@rustbot```` label: T-compiler F-inline_const
…crum Remove unneeded access to pretty printer's `s` field in favor of deref I found it taxing in some of my recent PRs touching the pretty printer to maintain consistency with the surrounding code, since the current code is all over the place about whether it uses `self.s.…()` or `self.…()` for invoking methods of `rustc_ast_pretty::pp::Printer`. This PR standardizes on `self.…()` — relying on the `Deref` and `DerefMut` impls introduced by [rust-lang#62532](rust-lang@cab4532).
…omez Link to rustdoc_json_types docs instead of rustdoc-json RFC The JSON format has had [many changes](https://github.com/rust-lang/rust/commits/master/src/rustdoc-json-types) since the RFC, so the rustdoc output is the only up to date reference ```@rustdoc``` modify labels: +A-rustdoc-json +A-docs
Update cargo 8 commits in 294967c53f0c70d598fc54ca189313c86c576ea7..40dc281755137ee804bc9b3b08e782773b726e44 2021-11-29 19:04:22 +0000 to 2021-12-06 21:54:44 +0000 - Unify the description of quiet flag (rust-lang/cargo#10168) - Stabilize future-incompat-report (rust-lang/cargo#10165) - Support abbreviating `--release` as `-r` (rust-lang/cargo#10133) - doc: nudge towards simple version requirements (rust-lang/cargo#10158) - Upgrade clap to 2.34.0 (rust-lang/cargo#10164) - Treat EOPNOTSUPP the same as ENOTSUP when ignoring failed flock calls. (rust-lang/cargo#10157) - Add note about RUSTFLAGS removal from build scripts. (rust-lang/cargo#10141) - Make clippy happy (rust-lang/cargo#10139)
…r=notriddle Add missing whitespace before disabled HTML attribute On the [w3c HTML checker](https://validator.w3.org/nu/#textarea), with the current generated HTML we get:  The problem was that we were telling tera to remove too many whitespace. r? ````@notriddle````
matthiaskrgr
commented
Dec 8, 2021
MemberAuthor
@bors r+ rollup=never p=7 |
bors
commented
Dec 8, 2021
Collaborator
📌 Commit 382426b has been approved by |
bors
commented
Dec 8, 2021
Collaborator
bors
commented
Dec 8, 2021
Collaborator
☀️ Test successful - checks-actions |
This was referenced Dec 8, 2021
This was referenced Dec 8, 2021
rust-timer
commented
Dec 9, 2021
Collaborator
Finished benchmarking commit (e6b883c): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
sfield in favor of deref #91571 (Remove unneeded access to pretty printer'ssfield in favor of deref)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup