Uh oh!
There was an error while loading. Please reload this page.
Sync portable-simd to fix libcore build for AVX-512 enabled targets - #92028
Merged
Conversation
Remove Select trait I realized that our `select` implementation predated `Simd` being generic over element type, and we don't really need the `Select` trait at all. The function signature is much simpler now (generic over element type, rather than over the entire vector). This did require changing mask select to be a different function, but I think that's fine considering they're not necessarily vectors.
rust-highfive
commented
Dec 17, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Dec 17, 2021
Member
@bors r+ |
bors
commented
Dec 17, 2021
Collaborator
📌 Commit 23c172f has been approved by |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 18, 2021
Sync portable-simd to fix libcore build for AVX-512 enabled targets Fixesrust-lang#91484 (comment) cc `@workingjubilee`
matthiaskrgr
commented
Dec 18, 2021
Member
Rollup failure: #92053 (comment) |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 18, 2021
Sync portable-simd to fix libcore build for AVX-512 enabled targets Fixesrust-lang#91484 (comment) cc `@workingjubilee`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91141 (Revert "Temporarily rename int_roundings functions to avoid conflicts") - rust-lang#91984 (Remove `in_band_lifetimes` from `rustc_middle`) - rust-lang#92028 (Sync portable-simd to fix libcore build for AVX-512 enabled targets) - rust-lang#92042 (Enable `#[thread_local]` for all windows-msvc targets) - rust-lang#92071 (Update example code for Vec::splice to change the length) - rust-lang#92077 (rustdoc: Remove unused `collapsed` field) - rust-lang#92081 (rustdoc: Remove unnecessary `need_backline` function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#91484 (comment)
cc @workingjubilee