Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Remove unused collapsed field - #92077
Merged
Merged
Conversation
`render/context` always runs after `run_global_context`, so it was always set to `true`. This is a holdover from when rustdoc allowed configuring passes, but the `collapse-docs` pass was removed ages ago, and the ability to configure passes is about to be removed.
rust-highfive
commented
Dec 18, 2021
Contributor
Some changes occurred in cc @camelid |
rust-highfive
commented
Dec 18, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
jyn514
commented
Dec 18, 2021
MemberAuthor
r? @camelid |
GuillaumeGomez
approved these changes
Dec 18, 2021
jyn514
commented
Dec 18, 2021
MemberAuthor
@bors r=GuillaumeGomez rollup Thanks for the review! |
bors
commented
Dec 18, 2021
Collaborator
📌 Commit dea1c68 has been approved by |
This was referenced Dec 18, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91141 (Revert "Temporarily rename int_roundings functions to avoid conflicts") - rust-lang#91984 (Remove `in_band_lifetimes` from `rustc_middle`) - rust-lang#92028 (Sync portable-simd to fix libcore build for AVX-512 enabled targets) - rust-lang#92042 (Enable `#[thread_local]` for all windows-msvc targets) - rust-lang#92071 (Update example code for Vec::splice to change the length) - rust-lang#92077 (rustdoc: Remove unused `collapsed` field) - rust-lang#92081 (rustdoc: Remove unnecessary `need_backline` function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render/contextalways runs afterrun_global_context, so it was always set totrue.This is a holdover from when rustdoc allowed configuring passes, but the
collapse-docspass wasremoved ages ago, and the ability to configure passes is about to be removed.
Found while reviewing #91305.