Add release notes for 1.58 by tmandry · Pull Request #92055 · rust-lang/rust

tmandry · 2021-12-18T03:33:02Z

r? @rust-lang/release

rust-highfive · 2021-12-18T03:33:04Z

(rust-highfive has picked a reviewer for you, use r? to override)

Co-authored-by: Hans Kratz <hans@appfour.com> Co-authored-by: Chris Denton <ChrisDenton@users.noreply.github.com> Co-authored-by: Joshua Nelson <github@jyn.dev>

tmandry · 2021-12-23T01:43:38Z

All comments have been addressed (cc @rust-lang/release again).

I'm officially on vacation starting tomorrow; I may check back here, but feel free to push to my branch / merge without me.

Co-authored-by: Josh Triplett <josh@joshtriplett.org> Co-authored-by: Alexander Ronald Altman <alexanderaltman@me.com>

emilyalbini · 2022-01-08T11:24:19Z

@bors r+ rollup

bors · 2022-01-08T11:24:21Z

📌 Commit 81963b1 has been approved by pietroalbini

marmeladema · 2022-01-08T14:23:10Z

+- [`Duration::checked_mul`]
+- [`Duration::saturating_mul`]
+- [`Duration::checked_div`]
+- [`Duration::as_secs_f64`]


I don't think any of the float methods are actually usable in const context: https://github.com/rust-lang/rust/blob/master/library/core/src/time.rs#L686
#89542 only stabilized:
implDuration{pubconstfnnew(secs:u64,nanos:u32) -> Duration;pubconstfnchecked_add(self,rhs:Duration) -> Option<Duration>;pubconstfnsaturating_add(self,rhs:Duration) -> Duration;pubconstfnchecked_sub(self,rhs:Duration) -> Option<Duration>;pubconstfnsaturating_sub(self,rhs:Duration) -> Duration;pubconstfnchecked_mul(self,rhs:u32) -> Option<Duration>;pubconstfnsaturating_mul(self,rhs:u32) -> Duration;pubconstfnchecked_div(self,rhs:u32) -> Option<Duration>;}

cc @pietroalbini @tmandry

Confirming this comment is correct.

emilyalbini · 2022-01-08T17:23:05Z

Good catch @marmeladema, I'll fix it in a bit.

@bors r-

emilyalbini · 2022-01-08T20:34:27Z

@bors r+ rollup

bors · 2022-01-08T20:34:28Z

📌 Commit 0e13d0c has been approved by pietroalbini

marmeladema · 2022-01-08T20:43:22Z

+[`Duration::checked_mul`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.checked_mul
+[`Duration::saturating_mul`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.saturating_mul
+[`Duration::checked_div`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.checked_div
+[`Duration::as_secs_f64`]: https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.as_secs_f64


Do we also want to remove those references?

That shouldn't be publicly visible, someone can open a PR later removing that.

…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92055 (Add release notes for 1.58) - rust-lang#92490 (Move crate drop-down to search results page) - rust-lang#92510 (Don't resolve blocks in foreign functions) - rust-lang#92573 (expand: Refactor InvocationCollector visitor for better code reuse) - rust-lang#92608 (rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes) - rust-lang#92657 (Implemented const casts of raw pointers) - rust-lang#92671 (Make `Atomic*::from_mut` return `&mut Atomic*`) - rust-lang#92673 (Remove useless collapse toggle on "all items" page) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Sign in to view

+- [`Metadata::is_symlink`]
+- [`Path::is_symlink`]
+- [`{integer}::saturating_div`]
+- [`Option::unwrap_unchecked`]


rust-highfive assigned Mark-Simulacrum Dec 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2021

jyn514 reviewed Dec 18, 2021
View reviewed changes

Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated

hkratz reviewed Dec 18, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

ChrisDenton reviewed Dec 18, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

CryZe reviewed Dec 18, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

jyn514 added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Dec 18, 2021

PatchMixolydic reviewed Dec 19, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

tmandry force-pushed the relnotes-1.58 branch from 8c6bb58 to e0a118cCompare December 21, 2021 23:05

jyn514 reviewed Dec 21, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

tmandry force-pushed the relnotes-1.58 branch from e0a118c to ef91d2bCompare December 23, 2021 01:23

tmandryand others added 3 commits December 23, 2021 01:25

Add release notes for 1.58
9b588a6

Apply suggestions from code review
0928e52
Co-authored-by: Hans Kratz <hans@appfour.com> Co-authored-by: Chris Denton <ChrisDenton@users.noreply.github.com> Co-authored-by: Joshua Nelson <github@jyn.dev>

Move RUSTFLAGS compat note to 1.55
8fd6e8b

tmandry force-pushed the relnotes-1.58 branch from ef91d2b to 0928e52Compare December 23, 2021 01:28

Add links to stabilized APIs
e2c659b

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

joshtriplett reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

pthariensflame reviewed Dec 24, 2021
View reviewed changes

Comment threadRELEASES.md Outdated

tmandryand others added 2 commits January 4, 2022 17:03

Apply suggestions from code review
3d2b8a2
Co-authored-by: Josh Triplett <josh@joshtriplett.org> Co-authored-by: Alexander Ronald Altman <alexanderaltman@me.com>

Moverust-lang#90329to compatibility notes
c3a99d8

tmandry force-pushed the relnotes-1.58 branch from 3dc7902 to c3a99d8Compare January 5, 2022 01:09

emilyalbini reviewed Jan 7, 2022
View reviewed changes

Comment threadRELEASES.md

tmandry added 2 commits January 7, 2022 16:48

Fix broken link
dd9501f

Clarify that -C strip is only in rustc, not cargo, in 1.58
81963b1

Mark-Simulacrum assigned emilyalbini and unassigned Mark-Simulacrum Jan 7, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2022

marmeladema reviewed Jan 8, 2022
View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2022

emilyalbini reviewed Jan 8, 2022
View reviewed changes

Comment threadRELEASES.md Outdated

remove float methods
0e13d0c

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2022

marmeladema reviewed Jan 8, 2022
View reviewed changes

matthiaskrgr mentioned this pull request Jan 9, 2022
Rollup of 8 pull requests #92690
Merged

bors merged commit 8dc3bf7 into rust-lang:masterJan 9, 2022

rustbot added this to the 1.60.0 milestone Jan 9, 2022

ojeda reviewed Jan 9, 2022
View reviewed changes

Comment threadRELEASES.md
- [`Metadata::is_symlink`]
- [`Path::is_symlink`]
- [`{integer}::saturating_div`]
- [`Option::unwrap_unchecked`]
This comment was marked as outdated.
Sign in to view
This comment was marked as outdated.
Sign in to view

tmandry deleted the relnotes-1.58 branch January 10, 2022 16:28

fmease mentioned this pull request Nov 25, 2024
Meta tracking issue for release notes PRs #133444
Open

Uh oh!

Uh oh!

Conversation

tmandry commented Dec 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Dec 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tmandry commented Dec 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emilyalbini commented Jan 8, 2022

Uh oh!

bors commented Jan 8, 2022

Uh oh!

marmelademaJan 8, 2022

Choose a reason for hiding this comment

Uh oh!

marmelademaJan 8, 2022

Choose a reason for hiding this comment

Uh oh!

jhprattJan 8, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilyalbini commented Jan 8, 2022

Uh oh!

Uh oh!

emilyalbini commented Jan 8, 2022

Uh oh!

bors commented Jan 8, 2022

Uh oh!

marmelademaJan 8, 2022

Choose a reason for hiding this comment

Uh oh!

emilyalbiniJan 9, 2022

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

tmandry commented Dec 18, 2021•
edited
Loading

jhprattJan 8, 2022•
edited
Loading