Skip to content

rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes - #92608

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:doctrscope3
Jan 9, 2022
Merged

rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes#92608
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:doctrscope3

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

The refactoring parts of #88679, shouldn't cause any slowdowns.
r? @jyn514

@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 6, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2022
petrochenkov
petrochenkov commented Jan 6, 2022
View reviewed changes
Comment threadsrc/librustdoc/passes/collect_trait_impls.rs Outdated
@petrochenkovpetrochenkov mentioned this pull request Jan 6, 2022
Merged
@jyn514

jyn514 commented Jan 6, 2022

Copy link
Copy Markdown
Member

I'm on vacation for a while.

r? rust-lang/rustdoc

@jyn514

jyn514 commented Jan 6, 2022

Copy link
Copy Markdown
Member

cc @CraftSpider

@CraftSpider

CraftSpider commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

I'll try to review this tonight once I'm out of work

CraftSpider
CraftSpider reviewed Jan 7, 2022
View reviewed changes

@CraftSpiderCraftSpider left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, just have a couple questions before I feel comfortable approving this.

Comment threadcompiler/rustc_middle/src/query/mod.rs Outdated
Comment threadsrc/librustdoc/passes/collect_intra_doc_links/early.rs Outdated
Comment threadsrc/librustdoc/passes/collect_trait_impls.rs Outdated
Comment threadsrc/librustdoc/passes/collect_trait_impls.rs Outdated
Comment threadsrc/librustdoc/passes/collect_intra_doc_links/early.rs Outdated
@bors

This comment has been minimized.

Sign in to view
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2022
@petrochenkovpetrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2022
@CraftSpider

CraftSpider commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

Thanks for the changes and comments, looks good
@bors r+

@bors

bors commented Jan 8, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 5acd1f9 has been approved by CraftSpider

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2022
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2022
@bors
Auto merge ofrust-lang#92690- matthiaskrgr:rollup-rw0oz05, r=matthi…
f7bb8e3
…askrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#92055 (Add release notes for 1.58)
- rust-lang#92490 (Move crate drop-down to search results page)
- rust-lang#92510 (Don't resolve blocks in foreign functions)
- rust-lang#92573 (expand: Refactor InvocationCollector visitor for better code reuse)
- rust-lang#92608 (rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes)
- rust-lang#92657 (Implemented const casts of raw pointers)
- rust-lang#92671 (Make `Atomic*::from_mut` return `&mut Atomic*`)
- rust-lang#92673 (Remove useless collapse toggle on "all items" page)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 51001b3 into rust-lang:masterJan 9, 2022
@rustbotrustbot added this to the 1.60.0 milestone Jan 9, 2022
dario23 added a commit to dario23/rust-semverver that referenced this pull request May 4, 2022
@dario23
FIXME: update torust-lang/rust#92608
e66f3cb
dario23 added a commit to dario23/rust-semverver that referenced this pull request May 6, 2022
@dario23
Rustup torust-lang/rust#92608
1aff824
@petrochenkov
petrochenkov deleted the doctrscope3 branch February 22, 2025 18:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CraftSpiderCraftSpiderCraftSpider left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CraftSpiderCraftSpider

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

6 participants

@petrochenkov@jyn514@CraftSpider@bors@rust-highfive@rustbot