Skip to content

update char signess for openbsd - #92061

Merged
bors merged 2 commits into
rust-lang:masterfrom
semarie:openbsd-archs
Mar 3, 2022
Merged

update char signess for openbsd#92061
bors merged 2 commits into
rust-lang:masterfrom
semarie:openbsd-archs

Conversation

@semarie

@semariesemarie commented Dec 18, 2021

Copy link
Copy Markdown
Contributor

it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.

@rust-highfive

rust-highfive commented Dec 18, 2021

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2021
@sanxiynsanxiyn added the O-openbsd Operating system: OpenBSD label Jan 5, 2022
@semarie

semarie commented Jan 6, 2022

Copy link
Copy Markdown
ContributorAuthor

ping ?

@camelidcamelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2022
@bors

bors commented Jan 28, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #93390) made this pull request unmergeable. Please resolve the merge conflicts.

@semarie

semarie commented Jan 28, 2022

Copy link
Copy Markdown
ContributorAuthor

updated commit after #91641

@bors

bors commented Jan 29, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #93351) made this pull request unmergeable. Please resolve the merge conflicts.

@semariesemarie closed this Jan 29, 2022
@semariesemarie reopened this Jan 29, 2022
@semariesemarie changed the title update libc to 0.2.112 and update char signess for openbsdupdate char signess for openbsdJan 29, 2022
@semarie

semarie commented Jan 29, 2022

Copy link
Copy Markdown
ContributorAuthor

updated commit after #93351

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@semarie

semarie commented Jan 29, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

the CI failure doesn't seems related. Lot of others CI actions (without my changes) are failing the same way. See #93384

@semarie

semarie commented Feb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

ping ?

@bors

bors commented Mar 2, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #94514) made this pull request unmergeable. Please resolve the merge conflicts.

Sébastien Marie
update char signess for openbsd
3768f0b
adds more archs for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@semarie

semarie commented Mar 2, 2022

Copy link
Copy Markdown
ContributorAuthor

updated commit after #94503

@joshtriplett

joshtriplett commented Mar 2, 2022•
edited
Loading

Copy link
Copy Markdown
Member

I don't know OpenBSD (and I don't think other reviewers do either), but this seems reasonable given that it matches the same architecture list for other target OSes.

On the assumption that this is likely to remain true, could you just merge this list with the one for freebsd, since it now matches the target list exactly?

r=me with that change.

@semarie

semarie commented Mar 2, 2022

Copy link
Copy Markdown
ContributorAuthor

I manually checked the char signess for all the platforms, or by directly check on the hardware, or with clang (and crosscompilation).

$ clang -target riscv64-unknown-openbsd -x c -dM -E - </dev/null | grep _CHAR_
#define __CHAR_BIT__ 8
#define __CHAR_UNSIGNED__ 1
#define __CLANG_ATOMIC_CHAR_LOCK_FREE 2
#define __GCC_ATOMIC_CHAR_LOCK_FREE 2
$ clang -target x86_64-unknown-openbsd -x c -dM -E - </dev/null | grep _CHAR_
#define __CHAR_BIT__ 8
#define __CLANG_ATOMIC_CHAR_LOCK_FREE 2
#define __GCC_ATOMIC_CHAR_LOCK_FREE 2

Technically, there is no requirement for char signess to be the same, but as it is the case currently, I will merge them.
thanks

@semarie

semarie commented Mar 2, 2022

Copy link
Copy Markdown
ContributorAuthor

I have merged freebsd and openbsd definition.

@joshtriplett

joshtriplett commented Mar 2, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 2, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit fa8e1be has been approved by joshtriplett

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge ofrust-lang#92061- semarie:openbsd-archs, r=joshtriplett
5afcfac
update char signess for openbsd
it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 2, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge ofrust-lang#92061- semarie:openbsd-archs, r=joshtriplett
d840a6e
update char signess for openbsd
it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 2, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge ofrust-lang#92061- semarie:openbsd-archs, r=joshtriplett
e7a6375
update char signess for openbsd
it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 2, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge ofrust-lang#92061- semarie:openbsd-archs, r=joshtriplett
eee74bf
update char signess for openbsd
it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgrmatthiaskrgr mentioned this pull request Mar 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 2, 2022
@Dylan-DPC
Rollup merge ofrust-lang#92061- semarie:openbsd-archs, r=joshtriplett
1a5f884
update char signess for openbsd
it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
This was referenced Mar 2, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2022
@bors
Auto merge ofrust-lang#94541- Dylan-DPC:rollup-564wbq3, r=Dylan-DPC
2f8d1a8
Rollup of 9 pull requests
Successful merges:
- rust-lang#92061 (update char signess for openbsd)
- rust-lang#93072 (Compatible variants suggestion with desugaring)
- rust-lang#93354 (Add documentation about `BorrowedFd::to_owned`.)
- rust-lang#93663 (Rename `BorrowedFd::borrow_raw_fd` to `BorrowedFd::borrow_raw`.)
- rust-lang#94375 (Adt copy suggestions)
- rust-lang#94433 (Improve allowness of the unexpected_cfgs lint)
- rust-lang#94499 (Documentation was missed when demoting Windows XP to no_std only)
- rust-lang#94505 (Restore the local filter on mono item sorting)
- rust-lang#94529 (Unused doc comments blocks)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a83021b into rust-lang:masterMar 3, 2022
@rustbotrustbot added this to the 1.61.0 milestone Mar 3, 2022
@semarie
semarie deleted the openbsd-archs branch August 26, 2022 06:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joshtriplettjoshtriplett

Labels

O-openbsdOperating system: OpenBSDS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

8 participants

@semarie@rust-highfive@bors@rust-log-analyzer@joshtriplett@sanxiyn@camelid@rustbot