Skip to content

Compatible variants suggestion with desugaring - #93072

Merged
bors merged 3 commits into
rust-lang:masterfrom
m-ou-se:compatible-variants-suggestion-with-desugaring
Mar 3, 2022
Merged

Compatible variants suggestion with desugaring#93072
bors merged 3 commits into
rust-lang:masterfrom
m-ou-se:compatible-variants-suggestion-with-desugaring

Conversation

@m-ou-se

Copy link
Copy Markdown
Member

This fixes#90553 for for loops and other desugarings.

r? @estebank

@m-ou-sem-ou-se added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` labels Jan 19, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2022
@estebank

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 17, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit ad663a2 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 17, 2022
…ion-with-desugaring, r=estebank
Compatible variants suggestion with desugaring
This fixesrust-lang#90553 for `for` loops and other desugarings.
r? `@estebank`
@ehuss

Copy link
Copy Markdown
Contributor

@bors r-

Failed in rollup: #94104 (comment)

Looks like it needs to be rebased and bless tests.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2022
@matthiaskrgr

Copy link
Copy Markdown
Member

Ah welp @ehuss was 20 minutes ahead of me. :D

@estebank

Copy link
Copy Markdown
Contributor

r=me after rebless/rebase (rrr?)

@m-ou-se
m-ou-seforce-pushed the compatible-variants-suggestion-with-desugaring branch from ad663a2 to b32cabfCompareMarch 2, 2022 18:30
@m-ou-se

Copy link
Copy Markdown
MemberAuthor

@bors r=estebank

@bors

bors commented Mar 2, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit b32cabf has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 2, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
…ion-with-desugaring, r=estebank
Compatible variants suggestion with desugaring
This fixesrust-lang#90553 for `for` loops and other desugarings.
r? `@estebank`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 2, 2022
…ion-with-desugaring, r=estebank
Compatible variants suggestion with desugaring
This fixesrust-lang#90553 for `for` loops and other desugarings.
r? ``@estebank``
@Dylan-DPCDylan-DPC mentioned this pull request Mar 2, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Mar 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2022
Rollup of 9 pull requests
Successful merges:
- rust-lang#92061 (update char signess for openbsd)
- rust-lang#93072 (Compatible variants suggestion with desugaring)
- rust-lang#93354 (Add documentation about `BorrowedFd::to_owned`.)
- rust-lang#93663 (Rename `BorrowedFd::borrow_raw_fd` to `BorrowedFd::borrow_raw`.)
- rust-lang#94375 (Adt copy suggestions)
- rust-lang#94433 (Improve allowness of the unexpected_cfgs lint)
- rust-lang#94499 (Documentation was missed when demoting Windows XP to no_std only)
- rust-lang#94505 (Restore the local filter on mono item sorting)
- rust-lang#94529 (Unused doc comments blocks)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bdad4a7 into rust-lang:masterMar 3, 2022
@rustbotrustbot added this to the 1.61.0 milestone Mar 3, 2022
@m-ou-se
m-ou-se deleted the compatible-variants-suggestion-with-desugaring branch March 9, 2022 14:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-diagnosticsArea: Messages for errors, warnings, and lintsA-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Special case suggestion for missing tail expression when dealing with Ok(()) and Some(())

7 participants

@m-ou-se@estebank@bors@ehuss@matthiaskrgr@rust-highfive@rustbot