Uh oh!
There was an error while loading. Please reload this page.
RustWrapper: adapt to new AttributeMask API - #92559
Merged
Merged
Conversation
Upstream LLVM change 9290ccc migrated attribute removal to use AttributeMask instead of AttrBuilder, so we need to follow suit here.
rust-highfive
commented
Jan 4, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon. Please see the contribution instructions for more information. |
nikic
reviewed
Jan 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
Avoids some extra conversions. Spotted by nikic during review.
nikic
commented
Jan 5, 2022
Contributor
@bors r+ rollup |
bors
commented
Jan 5, 2022
Collaborator
📌 Commit 34a6b6c has been approved by |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 6, 2022
RustWrapper: adapt to new AttributeMask API Upstream LLVM change 9290ccc migrated attribute removal to use AttributeMask instead of AttrBuilder, so we need to follow suit here. r? `@nagisa` cc `@nikic`
This was referenced Jan 6, 2022
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#91055 (return the correct type for closures in `type_of`) - rust-lang#92207 (Delay remaining `span_bug`s in drop elaboration) - rust-lang#92417 (Fix spacing and ordering of words in pretty printed Impl) - rust-lang#92504 (Exit nonzero on rustc -Wall) - rust-lang#92559 (RustWrapper: adapt to new AttributeMask API) - rust-lang#92589 (Break the loop) - rust-lang#92607 (rustc_metadata: Some minor cleanups and optimizations) - rust-lang#92620 (Remove unused `ExtendDefault` struct) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream LLVM change 9290ccc migrated attribute removal to use
AttributeMask instead of AttrBuilder, so we need to follow suit here.
r? @nagisa cc @nikic