Skip to content

rustc_metadata: Some minor cleanups and optimizations - #92607

Merged
bors merged 4 commits into
rust-lang:masterfrom
petrochenkov:doctrscope2
Jan 7, 2022
Merged

rustc_metadata: Some minor cleanups and optimizations#92607
bors merged 4 commits into
rust-lang:masterfrom
petrochenkov:doctrscope2

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Mostly extracted from #88679 (which is otherwise a rustdoc PR).
r? @cjgillot

Rename `CStore::item_attrs` -> `CStore::item_attrs_untracked` top follow conventions
By avoiding formatting and allocations in the no-ident case, and by making the span mandatory if the ident exists.
Use the optimized `opt_item_ident` to cleanup `fn each_child_of_item`
@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 6, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2022
@cjgillot

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 1b88007 has been approved by cjgillot

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 6, 2022
rustc_metadata: Some minor cleanups and optimizations
Mostly extracted from rust-lang#88679 (which is otherwise a rustdoc PR).
r? `@cjgillot`
This was referenced Jan 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2022
…askrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#91055 (return the correct type for closures in `type_of`)
- rust-lang#92207 (Delay remaining `span_bug`s in drop elaboration)
- rust-lang#92417 (Fix spacing and ordering of words in pretty printed Impl)
- rust-lang#92504 (Exit nonzero on rustc -Wall)
- rust-lang#92559 (RustWrapper: adapt to new AttributeMask API)
- rust-lang#92589 (Break the loop)
- rust-lang#92607 (rustc_metadata: Some minor cleanups and optimizations)
- rust-lang#92620 (Remove unused `ExtendDefault` struct)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 140b6cb into rust-lang:masterJan 7, 2022
@rustbotrustbot added this to the 1.59.0 milestone Jan 7, 2022
@petrochenkov
petrochenkov deleted the doctrscope2 branch February 22, 2025 18:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@cjgillot@bors@rust-highfive@rustbot