adjust sidebar link brightness

[conradludgate]

Fairly simple change. I've taken the existing link colour and main body background colours, and made sure that the sidebar+link contrast is the same.

ayu:

• main content contrast - 7.31
• current sidebar contrast - 6.97
• new sidebar contrast - 7.30

dark:

• main content contrast - 4.86
• current sidebar contrast - 3.19
• new sidebar contrast - 4.87

light:

• main content contrast - 4.97
• current sidebar contrast - 4.56
• new sidebar contrast - 4.97

[rust-highfive]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @notriddle (or someone else) soon.

Please see the contribution instructions for more information.

[GuillaumeGomez]

Your new CSS rule doesn't seem to be applied on the current item. Is it voluntary? Here is what the output looks like:

[conradludgate]

There seems to be a separate rule which defines the selected item colour:

rust/src/librustdoc/html/static/css/themes/dark.css

Line 158 in 05dd1e4

.contentspan.trait, .contenta.trait, .blocka.current.trait { color:#b78cf2; }

Are you suggesting we should apply the same contrast scaling to these?

[GuillaumeGomez]

If there is a contrast "problem" there as well, then yes.

[notriddle]

Needs to fix the sidebar.goml test case failure. Other than that, this looks great. Thanks!

/checkout/src/test/rustdoc-gui/sidebar.goml sidebar... FAILED
9846
Error: (line 12) Error: Evaluation failed: expected `rgb(56, 115, 173)` for key `color` for selector `#all-types`, found `rgb(53, 109, 164)`: for command `assert-css: ("#all-types", {"color": "rgb(56, 115, 173)"})`

[jsha]

Very nice, thanks for working on this!

Related to: #93230

[notriddle]

@bors r+

[bors]

📌 Commit ca3d0e2 has been approved by notriddle

[GuillaumeGomez]

@bors rollup