Uh oh!
There was an error while loading. Please reload this page.
Add white-space: nowrap to links in the sidebar - #93286
Merged
Merged
Conversation
We already have overflow: hidden on these links, but if there is a possibility to wrap, they will wrap. This happens in particular for trait implementations because the punctuation (`<>, `) introduces opportunities for breaks. That produces inconsistent UI. Fix it by forcing them not to wrap.
rust-highfive
commented
Jan 25, 2022
Contributor
Some changes occurred in HTML/CSS/JS. |
GuillaumeGomez
commented
Jan 25, 2022
Member
So just to make it more obvious. Before this PR:
After this PR:
I have to admit that I'm not a big fan of this change... |
camelid
commented
Jan 25, 2022
Member
Sorry, I don't have time to take on more PRs right now. r? @notriddle |
jsha
commented
Jan 25, 2022
ContributorAuthor
@GuillaumeGomez I think you have before and after reversed. Before: After:
|
Member
Oh indeed, you're absolutely right! My bad. Then I'm 100% for this change! :) @bors: r+ rollup |
bors
commented
Jan 25, 2022
Collaborator
📌 Commit abffd4a has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 25, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#93250 (Remove deduplication of early lints) - rust-lang#93286 (Add white-space: nowrap to links in the sidebar) - rust-lang#93291 (minor fix for rust-lang#93231) - rust-lang#93300 (make Windows abort_internal Miri-compatible) - rust-lang#93303 (Fix ICE when parsing bad turbofish with lifetime argument) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have overflow: hidden on these links, but if there is a possibility to wrap, they will wrap. This happens in particular for trait implementations because the punctuation (
<>,) introduces opportunities for breaks. That produces inconsistent UI. Fix it by forcing them not to wrap.Demo: https://rustdoc.crud.net/jsha/sidebar-nowrap/std/string/struct.String.html
To see the effect, scroll down to the "Trait Implementations" portion of the sidebar and look at IndexMut. Compare vs:
https://doc.rust-lang.org/std/string/struct.String.html
https://doc.rust-lang.org/nightly/std/string/struct.String.html
r? @camelid