Skip to content

Change Termination::report return type to ExitCode - #93442

Merged
bors merged 2 commits into
rust-lang:masterfrom
yaahc:Termination-abstraction
Feb 1, 2022
Merged

Change Termination::report return type to ExitCode#93442
bors merged 2 commits into
rust-lang:masterfrom
yaahc:Termination-abstraction

Conversation

@yaahc

@yaahcyaahc commented Jan 28, 2022

Copy link
Copy Markdown
Member

Related to #43301

The goal of this change is to minimize the forward compatibility risks in stabilizing Termination. By using the opaque type ExitCode instead of an i32 we leave room for us to evolve the API over time to provide what cross-platform consistency we can / minimize footguns when working with exit codes, where as stabilizing on i32 would limit what changes we could make in the future in how we represent and construct exit codes.

@rust-highfive

rust-highfive commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2022
@yaahcyaahc added T-libs-api [DEPRECATED; DO NOT USE] and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2022
scottmcm
scottmcm reviewed Jan 28, 2022
View reviewed changes
Comment threadlibrary/test/src/lib.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc

yaahc commented Jan 28, 2022

Copy link
Copy Markdown
MemberAuthor

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)

These test failures are unrelated to the changes in this PR: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Spurious.20mir-opt.20segfaults.20GHA/near/269699225

@yaahcyaahc added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2022
Mark-Simulacrum
Mark-Simulacrum reviewed Jan 31, 2022
View reviewed changes
Comment threadlibrary/std/src/process.rs
@Mark-Simulacrum

Mark-Simulacrum commented Jan 31, 2022

Copy link
Copy Markdown
Member

I will note that without even a PartialEq or is_success/is_failure methods, this makes the ExitCode basically useless outside unstable code modulo passing up to fn main. That seems plausibly OK, but fairly weird for an API we would actually want to stabilize.

r=me with the one nit comment fixed and/or perf run to confirm no effects modulo it.

@bors rollup=never since regardless this'll probably perturb codegen for binaries a little.

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2022
@yaahc

yaahc commented Jan 31, 2022

Copy link
Copy Markdown
MemberAuthor

Awesome, resolved the inlining issue. Going to add the partial_eq / is_success question to the ExitCode tracking issue as an unresolved question for now.

@bors r=Mark-Simulacrum rollup=never

@bors

bors commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 19db85d has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 31, 2022
@yaahcyaahc mentioned this pull request Jan 31, 2022
Closed
1 task
@bors

bors commented Feb 1, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 19db85d with merge 2681f25...

@borsbors mentioned this pull request Feb 1, 2022
Merged
@bors

bors commented Feb 1, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 2681f25 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Feb 1, 2022
@bors
bors merged commit 2681f25 into rust-lang:masterFeb 1, 2022
@rustbotrustbot added this to the 1.60.0 milestone Feb 1, 2022
@borsbors mentioned this pull request Feb 1, 2022
Merged
@rust-timer

rust-timer commented Feb 2, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (2681f25): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@yuhryuhr mentioned this pull request Feb 9, 2022
Merged
@benediktwernerbenediktwerner mentioned this pull request May 19, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97170- benediktwerner:master, r=JohnTitor
1759747
Remove unnecessay .report() on ExitCode
Since rust-lang#93442, the return type is `ExitCode` anyway so there's no need to do a conversion using `.report()` (which is now just a no-op).
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 11, 2023
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@scottmcmscottmcmscottmcm left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yaahc@rust-highfive@rust-log-analyzer@Mark-Simulacrum@bors@rust-timer@scottmcm@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Change Termination::report return type to ExitCode by yaahc · Pull Request #93442 · rust-lang/rust · GitHub
Skip to content
Change Termination::report return type to ExitCode - #93442
Merged
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Feb 1, 2022
Merged
Change Termination::report return type to ExitCode#93442
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Conversation
@yaahc
@yaahcyaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

Member
Related to #43301
The goal of this change is to minimize the forward compatibility risks in stabilizing Termination. By using the opaque type ExitCode instead of an i32 we leave room for us to evolve the API over time to provide what cross-platform consistency we can / minimize footguns when working with exit codes, where as stabilizing on i32 would limit what changes we could make in the future in how we represent and construct exit codes.
@rust-highfive
rust-highfive
commented
Jan 28, 2022

Copy link


Copy Markdown

Contributor
r? @Mark-Simulacrum
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
@yaahcyaahc
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 28, 2022
scottmcm
scottmcm
reviewed
Jan 28, 2022
View reviewed changes
Comment threadlibrary/test/src/lib.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
yaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

MemberAuthor
The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
These test failures are unrelated to the changes in this PR: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Spurious.20mir-opt.20segfaults.20GHA/near/269699225
@yaahcyaahc
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
Mark-Simulacrum
Mark-Simulacrum
reviewed
Jan 31, 2022
View reviewed changes
Comment threadlibrary/std/src/process.rs
@Mark-Simulacrum
Mark-Simulacrum
commented
Jan 31, 2022

Copy link


Copy Markdown

Member
I will note that without even a PartialEq or is_success/is_failure methods, this makes the ExitCode basically useless outside unstable code modulo passing up to fn main. That seems plausibly OK, but fairly weird for an API we would actually want to stabilize.
r=me with the one nit comment fixed and/or perf run to confirm no effects modulo it.
@bors rollup=never since regardless this'll probably perturb codegen for binaries a little.
@Mark-SimulacrumMark-Simulacrum
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 31, 2022
@yaahc
yaahc
commented
Jan 31, 2022

Copy link


Copy Markdown

MemberAuthor
Awesome, resolved the inlining issue. Going to add the partial_eq / is_success question to the ExitCode tracking issue as an unresolved question for now.
@bors r=Mark-Simulacrum rollup=never
@bors
bors
commented
Jan 31, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 19db85d has been approved by Mark-Simulacrum
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 31, 2022
@yaahcyaahc
mentioned this pull request
Jan 31, 2022

Closed

1 task
@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 19db85d with merge 2681f25...
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: Mark-Simulacrum

Pushing 2681f25 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Feb 1, 2022
@bors
bors
merged commit 2681f25
into
rust-lang:masterFeb 1, 2022
@rustbotrustbot
added this to the 1.60.0 milestone
Feb 1, 2022
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@rust-timer
rust-timer
commented
Feb 2, 2022

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (2681f25): comparison url.
Summary: This benchmark run did not return any relevant results.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
@yuhryuhr
mentioned this pull request
Feb 9, 2022
 Merged

@benediktwernerbenediktwerner
mentioned this pull request
May 19, 2022
 Merged

Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97170- benediktwerner:master, r=JohnTitor
1759747
Remove unnecessay .report() on ExitCode
Since rust-lang#93442, the return type is `ExitCode` anyway so there's no need to do a conversion using `.report()` (which is now just a no-op).
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Aug 11, 2023

Closed

@matthiaskrgrmatthiaskrgr
mentioned this pull request
Nov 10, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@scottmcmscottmcmscottmcm left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yaahc@rust-highfive@rust-log-analyzer@Mark-Simulacrum@bors@rust-timer@scottmcm@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change Termination::report return type to ExitCode by yaahc · Pull Request #93442 · rust-lang/rust · GitHub
Skip to content
Change Termination::report return type to ExitCode - #93442
Merged
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Feb 1, 2022
Merged
Change Termination::report return type to ExitCode#93442
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Conversation
@yaahc
@yaahcyaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

Member
Related to #43301
The goal of this change is to minimize the forward compatibility risks in stabilizing Termination. By using the opaque type ExitCode instead of an i32 we leave room for us to evolve the API over time to provide what cross-platform consistency we can / minimize footguns when working with exit codes, where as stabilizing on i32 would limit what changes we could make in the future in how we represent and construct exit codes.
@rust-highfive
rust-highfive
commented
Jan 28, 2022

Copy link


Copy Markdown

Contributor
r? @Mark-Simulacrum
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
@yaahcyaahc
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 28, 2022
scottmcm
scottmcm
reviewed
Jan 28, 2022
View reviewed changes
Comment threadlibrary/test/src/lib.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
yaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

MemberAuthor
The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
These test failures are unrelated to the changes in this PR: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Spurious.20mir-opt.20segfaults.20GHA/near/269699225
@yaahcyaahc
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
Mark-Simulacrum
Mark-Simulacrum
reviewed
Jan 31, 2022
View reviewed changes
Comment threadlibrary/std/src/process.rs
@Mark-Simulacrum
Mark-Simulacrum
commented
Jan 31, 2022

Copy link


Copy Markdown

Member
I will note that without even a PartialEq or is_success/is_failure methods, this makes the ExitCode basically useless outside unstable code modulo passing up to fn main. That seems plausibly OK, but fairly weird for an API we would actually want to stabilize.
r=me with the one nit comment fixed and/or perf run to confirm no effects modulo it.
@bors rollup=never since regardless this'll probably perturb codegen for binaries a little.
@Mark-SimulacrumMark-Simulacrum
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 31, 2022
@yaahc
yaahc
commented
Jan 31, 2022

Copy link


Copy Markdown

MemberAuthor
Awesome, resolved the inlining issue. Going to add the partial_eq / is_success question to the ExitCode tracking issue as an unresolved question for now.
@bors r=Mark-Simulacrum rollup=never
@bors
bors
commented
Jan 31, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 19db85d has been approved by Mark-Simulacrum
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 31, 2022
@yaahcyaahc
mentioned this pull request
Jan 31, 2022

Closed

1 task
@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 19db85d with merge 2681f25...
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: Mark-Simulacrum

Pushing 2681f25 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Feb 1, 2022
@bors
bors
merged commit 2681f25
into
rust-lang:masterFeb 1, 2022
@rustbotrustbot
added this to the 1.60.0 milestone
Feb 1, 2022
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@rust-timer
rust-timer
commented
Feb 2, 2022

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (2681f25): comparison url.
Summary: This benchmark run did not return any relevant results.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
@yuhryuhr
mentioned this pull request
Feb 9, 2022
 Merged

@benediktwernerbenediktwerner
mentioned this pull request
May 19, 2022
 Merged

Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97170- benediktwerner:master, r=JohnTitor
1759747
Remove unnecessay .report() on ExitCode
Since rust-lang#93442, the return type is `ExitCode` anyway so there's no need to do a conversion using `.report()` (which is now just a no-op).
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Aug 11, 2023

Closed

@matthiaskrgrmatthiaskrgr
mentioned this pull request
Nov 10, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@scottmcmscottmcmscottmcm left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yaahc@rust-highfive@rust-log-analyzer@Mark-Simulacrum@bors@rust-timer@scottmcm@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change Termination::report return type to ExitCode by yaahc · Pull Request #93442 · rust-lang/rust · GitHub
Skip to content
Change Termination::report return type to ExitCode - #93442
Merged
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Feb 1, 2022
Merged
Change Termination::report return type to ExitCode#93442
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Conversation
@yaahc
@yaahcyaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

Member
Related to #43301
The goal of this change is to minimize the forward compatibility risks in stabilizing Termination. By using the opaque type ExitCode instead of an i32 we leave room for us to evolve the API over time to provide what cross-platform consistency we can / minimize footguns when working with exit codes, where as stabilizing on i32 would limit what changes we could make in the future in how we represent and construct exit codes.
@rust-highfive
rust-highfive
commented
Jan 28, 2022

Copy link


Copy Markdown

Contributor
r? @Mark-Simulacrum
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
@yaahcyaahc
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 28, 2022
scottmcm
scottmcm
reviewed
Jan 28, 2022
View reviewed changes
Comment threadlibrary/test/src/lib.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
yaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

MemberAuthor
The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
These test failures are unrelated to the changes in this PR: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Spurious.20mir-opt.20segfaults.20GHA/near/269699225
@yaahcyaahc
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
Mark-Simulacrum
Mark-Simulacrum
reviewed
Jan 31, 2022
View reviewed changes
Comment threadlibrary/std/src/process.rs
@Mark-Simulacrum
Mark-Simulacrum
commented
Jan 31, 2022

Copy link


Copy Markdown

Member
I will note that without even a PartialEq or is_success/is_failure methods, this makes the ExitCode basically useless outside unstable code modulo passing up to fn main. That seems plausibly OK, but fairly weird for an API we would actually want to stabilize.
r=me with the one nit comment fixed and/or perf run to confirm no effects modulo it.
@bors rollup=never since regardless this'll probably perturb codegen for binaries a little.
@Mark-SimulacrumMark-Simulacrum
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 31, 2022
@yaahc
yaahc
commented
Jan 31, 2022

Copy link


Copy Markdown

MemberAuthor
Awesome, resolved the inlining issue. Going to add the partial_eq / is_success question to the ExitCode tracking issue as an unresolved question for now.
@bors r=Mark-Simulacrum rollup=never
@bors
bors
commented
Jan 31, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 19db85d has been approved by Mark-Simulacrum
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 31, 2022
@yaahcyaahc
mentioned this pull request
Jan 31, 2022

Closed

1 task
@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 19db85d with merge 2681f25...
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: Mark-Simulacrum

Pushing 2681f25 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Feb 1, 2022
@bors
bors
merged commit 2681f25
into
rust-lang:masterFeb 1, 2022
@rustbotrustbot
added this to the 1.60.0 milestone
Feb 1, 2022
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@rust-timer
rust-timer
commented
Feb 2, 2022

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (2681f25): comparison url.
Summary: This benchmark run did not return any relevant results.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
@yuhryuhr
mentioned this pull request
Feb 9, 2022
 Merged

@benediktwernerbenediktwerner
mentioned this pull request
May 19, 2022
 Merged

Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97170- benediktwerner:master, r=JohnTitor
1759747
Remove unnecessay .report() on ExitCode
Since rust-lang#93442, the return type is `ExitCode` anyway so there's no need to do a conversion using `.report()` (which is now just a no-op).
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Aug 11, 2023

Closed

@matthiaskrgrmatthiaskrgr
mentioned this pull request
Nov 10, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@scottmcmscottmcmscottmcm left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yaahc@rust-highfive@rust-log-analyzer@Mark-Simulacrum@bors@rust-timer@scottmcm@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Change Termination::report return type to ExitCode by yaahc · Pull Request #93442 · rust-lang/rust · GitHub
Skip to content
Change Termination::report return type to ExitCode - #93442
Merged
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Feb 1, 2022
Merged
Change Termination::report return type to ExitCode#93442
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Conversation
@yaahc
@yaahcyaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

Member
Related to #43301
The goal of this change is to minimize the forward compatibility risks in stabilizing Termination. By using the opaque type ExitCode instead of an i32 we leave room for us to evolve the API over time to provide what cross-platform consistency we can / minimize footguns when working with exit codes, where as stabilizing on i32 would limit what changes we could make in the future in how we represent and construct exit codes.
@rust-highfive
rust-highfive
commented
Jan 28, 2022

Copy link


Copy Markdown

Contributor
r? @Mark-Simulacrum
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
@yaahcyaahc
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 28, 2022
scottmcm
scottmcm
reviewed
Jan 28, 2022
View reviewed changes
Comment threadlibrary/test/src/lib.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
yaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

MemberAuthor
The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
These test failures are unrelated to the changes in this PR: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Spurious.20mir-opt.20segfaults.20GHA/near/269699225
@yaahcyaahc
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
Mark-Simulacrum
Mark-Simulacrum
reviewed
Jan 31, 2022
View reviewed changes
Comment threadlibrary/std/src/process.rs
@Mark-Simulacrum
Mark-Simulacrum
commented
Jan 31, 2022

Copy link


Copy Markdown

Member
I will note that without even a PartialEq or is_success/is_failure methods, this makes the ExitCode basically useless outside unstable code modulo passing up to fn main. That seems plausibly OK, but fairly weird for an API we would actually want to stabilize.
r=me with the one nit comment fixed and/or perf run to confirm no effects modulo it.
@bors rollup=never since regardless this'll probably perturb codegen for binaries a little.
@Mark-SimulacrumMark-Simulacrum
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 31, 2022
@yaahc
yaahc
commented
Jan 31, 2022

Copy link


Copy Markdown

MemberAuthor
Awesome, resolved the inlining issue. Going to add the partial_eq / is_success question to the ExitCode tracking issue as an unresolved question for now.
@bors r=Mark-Simulacrum rollup=never
@bors
bors
commented
Jan 31, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 19db85d has been approved by Mark-Simulacrum
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 31, 2022
@yaahcyaahc
mentioned this pull request
Jan 31, 2022

Closed

1 task
@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 19db85d with merge 2681f25...
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: Mark-Simulacrum

Pushing 2681f25 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Feb 1, 2022
@bors
bors
merged commit 2681f25
into
rust-lang:masterFeb 1, 2022
@rustbotrustbot
added this to the 1.60.0 milestone
Feb 1, 2022
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@rust-timer
rust-timer
commented
Feb 2, 2022

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (2681f25): comparison url.
Summary: This benchmark run did not return any relevant results.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
@yuhryuhr
mentioned this pull request
Feb 9, 2022
 Merged

@benediktwernerbenediktwerner
mentioned this pull request
May 19, 2022
 Merged

Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97170- benediktwerner:master, r=JohnTitor
1759747
Remove unnecessay .report() on ExitCode
Since rust-lang#93442, the return type is `ExitCode` anyway so there's no need to do a conversion using `.report()` (which is now just a no-op).
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Aug 11, 2023

Closed

@matthiaskrgrmatthiaskrgr
mentioned this pull request
Nov 10, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@scottmcmscottmcmscottmcm left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yaahc@rust-highfive@rust-log-analyzer@Mark-Simulacrum@bors@rust-timer@scottmcm@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change Termination::report return type to ExitCode by yaahc · Pull Request #93442 · rust-lang/rust · GitHub
Skip to content
Change Termination::report return type to ExitCode - #93442
Merged
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Feb 1, 2022
Merged
Change Termination::report return type to ExitCode#93442
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Conversation
@yaahc
@yaahcyaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

Member
Related to #43301
The goal of this change is to minimize the forward compatibility risks in stabilizing Termination. By using the opaque type ExitCode instead of an i32 we leave room for us to evolve the API over time to provide what cross-platform consistency we can / minimize footguns when working with exit codes, where as stabilizing on i32 would limit what changes we could make in the future in how we represent and construct exit codes.
@rust-highfive
rust-highfive
commented
Jan 28, 2022

Copy link


Copy Markdown

Contributor
r? @Mark-Simulacrum
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
@yaahcyaahc
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 28, 2022
scottmcm
scottmcm
reviewed
Jan 28, 2022
View reviewed changes
Comment threadlibrary/test/src/lib.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
yaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

MemberAuthor
The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
These test failures are unrelated to the changes in this PR: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Spurious.20mir-opt.20segfaults.20GHA/near/269699225
@yaahcyaahc
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
Mark-Simulacrum
Mark-Simulacrum
reviewed
Jan 31, 2022
View reviewed changes
Comment threadlibrary/std/src/process.rs
@Mark-Simulacrum
Mark-Simulacrum
commented
Jan 31, 2022

Copy link


Copy Markdown

Member
I will note that without even a PartialEq or is_success/is_failure methods, this makes the ExitCode basically useless outside unstable code modulo passing up to fn main. That seems plausibly OK, but fairly weird for an API we would actually want to stabilize.
r=me with the one nit comment fixed and/or perf run to confirm no effects modulo it.
@bors rollup=never since regardless this'll probably perturb codegen for binaries a little.
@Mark-SimulacrumMark-Simulacrum
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 31, 2022
@yaahc
yaahc
commented
Jan 31, 2022

Copy link


Copy Markdown

MemberAuthor
Awesome, resolved the inlining issue. Going to add the partial_eq / is_success question to the ExitCode tracking issue as an unresolved question for now.
@bors r=Mark-Simulacrum rollup=never
@bors
bors
commented
Jan 31, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 19db85d has been approved by Mark-Simulacrum
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 31, 2022
@yaahcyaahc
mentioned this pull request
Jan 31, 2022

Closed

1 task
@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 19db85d with merge 2681f25...
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: Mark-Simulacrum

Pushing 2681f25 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Feb 1, 2022
@bors
bors
merged commit 2681f25
into
rust-lang:masterFeb 1, 2022
@rustbotrustbot
added this to the 1.60.0 milestone
Feb 1, 2022
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@rust-timer
rust-timer
commented
Feb 2, 2022

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (2681f25): comparison url.
Summary: This benchmark run did not return any relevant results.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
@yuhryuhr
mentioned this pull request
Feb 9, 2022
 Merged

@benediktwernerbenediktwerner
mentioned this pull request
May 19, 2022
 Merged

Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97170- benediktwerner:master, r=JohnTitor
1759747
Remove unnecessay .report() on ExitCode
Since rust-lang#93442, the return type is `ExitCode` anyway so there's no need to do a conversion using `.report()` (which is now just a no-op).
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Aug 11, 2023

Closed

@matthiaskrgrmatthiaskrgr
mentioned this pull request
Nov 10, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@scottmcmscottmcmscottmcm left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yaahc@rust-highfive@rust-log-analyzer@Mark-Simulacrum@bors@rust-timer@scottmcm@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Change Termination::report return type to ExitCode by yaahc · Pull Request #93442 · rust-lang/rust · GitHub
Skip to content
Change Termination::report return type to ExitCode - #93442
Merged
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Feb 1, 2022
Merged
Change Termination::report return type to ExitCode#93442
bors merged 2 commits into
rust-lang:masterfrom 
yaahc:Termination-abstraction
Conversation
@yaahc
@yaahcyaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

Member
Related to #43301
The goal of this change is to minimize the forward compatibility risks in stabilizing Termination. By using the opaque type ExitCode instead of an i32 we leave room for us to evolve the API over time to provide what cross-platform consistency we can / minimize footguns when working with exit codes, where as stabilizing on i32 would limit what changes we could make in the future in how we represent and construct exit codes.
@rust-highfive
rust-highfive
commented
Jan 28, 2022

Copy link


Copy Markdown

Contributor
r? @Mark-Simulacrum
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
@yaahcyaahc
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 28, 2022
scottmcm
scottmcm
reviewed
Jan 28, 2022
View reviewed changes
Comment threadlibrary/test/src/lib.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
yaahc
commented
Jan 28, 2022

Copy link


Copy Markdown

MemberAuthor
The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
These test failures are unrelated to the changes in this PR: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Spurious.20mir-opt.20segfaults.20GHA/near/269699225
@yaahcyaahc
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 28, 2022
Mark-Simulacrum
Mark-Simulacrum
reviewed
Jan 31, 2022
View reviewed changes
Comment threadlibrary/std/src/process.rs
@Mark-Simulacrum
Mark-Simulacrum
commented
Jan 31, 2022

Copy link


Copy Markdown

Member
I will note that without even a PartialEq or is_success/is_failure methods, this makes the ExitCode basically useless outside unstable code modulo passing up to fn main. That seems plausibly OK, but fairly weird for an API we would actually want to stabilize.
r=me with the one nit comment fixed and/or perf run to confirm no effects modulo it.
@bors rollup=never since regardless this'll probably perturb codegen for binaries a little.
@Mark-SimulacrumMark-Simulacrum
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 31, 2022
@yaahc
yaahc
commented
Jan 31, 2022

Copy link


Copy Markdown

MemberAuthor
Awesome, resolved the inlining issue. Going to add the partial_eq / is_success question to the ExitCode tracking issue as an unresolved question for now.
@bors r=Mark-Simulacrum rollup=never
@bors
bors
commented
Jan 31, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 19db85d has been approved by Mark-Simulacrum
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 31, 2022
@yaahcyaahc
mentioned this pull request
Jan 31, 2022

Closed

1 task
@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 19db85d with merge 2681f25...
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@bors
bors
commented
Feb 1, 2022

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: Mark-Simulacrum

Pushing 2681f25 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Feb 1, 2022
@bors
bors
merged commit 2681f25
into
rust-lang:masterFeb 1, 2022
@rustbotrustbot
added this to the 1.60.0 milestone
Feb 1, 2022
@borsbors
mentioned this pull request
Feb 1, 2022
 Merged

@rust-timer
rust-timer
commented
Feb 2, 2022

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (2681f25): comparison url.
Summary: This benchmark run did not return any relevant results.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
@yuhryuhr
mentioned this pull request
Feb 9, 2022
 Merged

@benediktwernerbenediktwerner
mentioned this pull request
May 19, 2022
 Merged

Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 19, 2022
@Dylan-DPC
Rollup merge ofrust-lang#97170- benediktwerner:master, r=JohnTitor
1759747
Remove unnecessay .report() on ExitCode
Since rust-lang#93442, the return type is `ExitCode` anyway so there's no need to do a conversion using `.report()` (which is now just a no-op).
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Aug 11, 2023

Closed

@matthiaskrgrmatthiaskrgr
mentioned this pull request
Nov 10, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@scottmcmscottmcmscottmcm left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yaahc@rust-highfive@rust-log-analyzer@Mark-Simulacrum@bors@rust-timer@scottmcm@rustbot