Skip to content

Remove unnecessay .report() on ExitCode - #97170

Merged
bors merged 1 commit into
rust-lang:masterfrom
benediktwerner:master
May 20, 2022
Merged

Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom
benediktwerner:master

Conversation

@benediktwerner

@benediktwernerbenediktwerner commented May 19, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 19, 2022
@rust-highfive

rust-highfive commented May 19, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented May 19, 2022

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2022
JohnTitor
JohnTitor approved these changes May 19, 2022
View reviewed changes

@JohnTitorJohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

@JohnTitor

JohnTitor commented May 19, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented May 19, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 7013dc5 has been approved by JohnTitor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2022
@Dylan-DPCDylan-DPC mentioned this pull request May 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1759747 into rust-lang:masterMay 20, 2022
@rustbotrustbot added this to the 1.63.0 milestone May 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove unnecessay .report() on ExitCode by benediktwerner · Pull Request #97170 · rust-lang/rust · GitHub
Skip to content
Remove unnecessay .report() on ExitCode - #97170
Merged
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
May 20, 2022
Merged
Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
Conversation
@benediktwerner
@benediktwernerbenediktwerner
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
May 19, 2022
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 19, 2022
JohnTitor
JohnTitor
approved these changes
May 19, 2022
View reviewed changes
@JohnTitorJohnTitor
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
@JohnTitor
JohnTitor
commented
May 19, 2022

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
May 19, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 7013dc5 has been approved by JohnTitor
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 19, 2022
@Dylan-DPCDylan-DPC
mentioned this pull request
May 19, 2022
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 1759747
into
rust-lang:masterMay 20, 2022
@rustbotrustbot
added this to the 1.63.0 milestone
May 20, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessay .report() on ExitCode by benediktwerner · Pull Request #97170 · rust-lang/rust · GitHub
Skip to content
Remove unnecessay .report() on ExitCode - #97170
Merged
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
May 20, 2022
Merged
Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
Conversation
@benediktwerner
@benediktwernerbenediktwerner
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
May 19, 2022
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 19, 2022
JohnTitor
JohnTitor
approved these changes
May 19, 2022
View reviewed changes
@JohnTitorJohnTitor
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
@JohnTitor
JohnTitor
commented
May 19, 2022

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
May 19, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 7013dc5 has been approved by JohnTitor
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 19, 2022
@Dylan-DPCDylan-DPC
mentioned this pull request
May 19, 2022
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 1759747
into
rust-lang:masterMay 20, 2022
@rustbotrustbot
added this to the 1.63.0 milestone
May 20, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessay .report() on ExitCode by benediktwerner · Pull Request #97170 · rust-lang/rust · GitHub
Skip to content
Remove unnecessay .report() on ExitCode - #97170
Merged
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
May 20, 2022
Merged
Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
Conversation
@benediktwerner
@benediktwernerbenediktwerner
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
May 19, 2022
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 19, 2022
JohnTitor
JohnTitor
approved these changes
May 19, 2022
View reviewed changes
@JohnTitorJohnTitor
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
@JohnTitor
JohnTitor
commented
May 19, 2022

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
May 19, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 7013dc5 has been approved by JohnTitor
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 19, 2022
@Dylan-DPCDylan-DPC
mentioned this pull request
May 19, 2022
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 1759747
into
rust-lang:masterMay 20, 2022
@rustbotrustbot
added this to the 1.63.0 milestone
May 20, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove unnecessay .report() on ExitCode by benediktwerner · Pull Request #97170 · rust-lang/rust · GitHub
Skip to content
Remove unnecessay .report() on ExitCode - #97170
Merged
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
May 20, 2022
Merged
Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
Conversation
@benediktwerner
@benediktwernerbenediktwerner
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
May 19, 2022
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 19, 2022
JohnTitor
JohnTitor
approved these changes
May 19, 2022
View reviewed changes
@JohnTitorJohnTitor
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
@JohnTitor
JohnTitor
commented
May 19, 2022

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
May 19, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 7013dc5 has been approved by JohnTitor
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 19, 2022
@Dylan-DPCDylan-DPC
mentioned this pull request
May 19, 2022
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 1759747
into
rust-lang:masterMay 20, 2022
@rustbotrustbot
added this to the 1.63.0 milestone
May 20, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessay .report() on ExitCode by benediktwerner · Pull Request #97170 · rust-lang/rust · GitHub
Skip to content
Remove unnecessay .report() on ExitCode - #97170
Merged
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
May 20, 2022
Merged
Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
Conversation
@benediktwerner
@benediktwernerbenediktwerner
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
May 19, 2022
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 19, 2022
JohnTitor
JohnTitor
approved these changes
May 19, 2022
View reviewed changes
@JohnTitorJohnTitor
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
@JohnTitor
JohnTitor
commented
May 19, 2022

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
May 19, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 7013dc5 has been approved by JohnTitor
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 19, 2022
@Dylan-DPCDylan-DPC
mentioned this pull request
May 19, 2022
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 1759747
into
rust-lang:masterMay 20, 2022
@rustbotrustbot
added this to the 1.63.0 milestone
May 20, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove unnecessay .report() on ExitCode by benediktwerner · Pull Request #97170 · rust-lang/rust · GitHub
Skip to content
Remove unnecessay .report() on ExitCode - #97170
Merged
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
May 20, 2022
Merged
Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
Conversation
@benediktwerner
@benediktwernerbenediktwerner
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
May 19, 2022
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 19, 2022
JohnTitor
JohnTitor
approved these changes
May 19, 2022
View reviewed changes
@JohnTitorJohnTitor
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
@JohnTitor
JohnTitor
commented
May 19, 2022

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
May 19, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 7013dc5 has been approved by JohnTitor
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 19, 2022
@Dylan-DPCDylan-DPC
mentioned this pull request
May 19, 2022
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 1759747
into
rust-lang:masterMay 20, 2022
@rustbotrustbot
added this to the 1.63.0 milestone
May 20, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove unnecessay .report() on ExitCode by benediktwerner · Pull Request #97170 · rust-lang/rust · GitHub
Skip to content
Remove unnecessay .report() on ExitCode - #97170
Merged
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
May 20, 2022
Merged
Remove unnecessay .report() on ExitCode#97170
bors merged 1 commit into
rust-lang:masterfrom 
benediktwerner:master
Conversation
@benediktwerner
@benediktwernerbenediktwerner
commented
May 19, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Since #93442, the return type is ExitCode anyway so there's no need to do a conversion using .report() (which is now just a no-op).
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
May 19, 2022
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rust-highfive
rust-highfive
commented
May 19, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 19, 2022
JohnTitor
JohnTitor
approved these changes
May 19, 2022
View reviewed changes
@JohnTitorJohnTitor
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!
@JohnTitor
JohnTitor
commented
May 19, 2022

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
May 19, 2022

Copy link


Copy Markdown

Collaborator
📌 Commit 7013dc5 has been approved by JohnTitor
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 19, 2022
@Dylan-DPCDylan-DPC
mentioned this pull request
May 19, 2022
 Merged

bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2022
@bors
Auto merge ofrust-lang#97180- Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d
Rollup of 6 pull requests
Successful merges:
- rust-lang#96539 (Add release notes for 1.61.0)
- rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
- rust-lang#97155 (Fix doc typo)
- rust-lang#97169 (Improve `u32 as char` cast diagnostic)
- rust-lang#97170 (Remove unnecessay .report() on ExitCode)
- rust-lang#97171 (Add regression test for rust-lang#88119)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit 1759747
into
rust-lang:masterMay 20, 2022
@rustbotrustbot
added this to the 1.63.0 milestone
May 20, 2022
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@benediktwerner@rust-highfive@JohnTitor@bors@joshtriplett@rustbot