Implement internal `IsZero` for Wrapping and Saturating for `Vec` optimizations by asquared31415 · Pull Request #93455 · rust-lang/rust

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

asquared31415 · 2022-01-29T13:06:37Z

This implements the IsZero trait for the Wrapping and Saturating types so that users of these types can get the improved performance from the specialization of creating a Vec from a single element repeated when it has a zero bit pattern (example vec![0_i32; 500], or after this PR vec![Wrapping(0_i32); 500])

CC #60978

rust-highfive · 2022-01-29T13:06:41Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

asquared31415 · 2022-01-30T04:45:38Z

I think this is a spurious CI failure

Dylan-DPC · 2022-04-11T22:44:04Z

r? @m-ou-se

thomcc · 2022-08-26T04:13:04Z

r? @thomcc

thomcc · 2022-08-26T04:15:27Z

This is fully internal and looks good to me. No rollup since this could help perf a fair bit in the off-chance we have uses of this inside rustc (this is pretty unlikely, though).

@bors r+ rollup=never

bors · 2022-08-26T04:15:29Z

📌 Commit 652c3fc811d977f620323cb7d8e63136d6b0207a has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-08-26T09:27:29Z

⌛ Testing commit 652c3fc811d977f620323cb7d8e63136d6b0207a with merge efb31449a452d93ed96b2c293a895b52ee257bfe...

bors · 2022-08-26T09:31:36Z

💔 Test failed - checks-actions

thomcc · 2022-08-26T20:12:50Z

Oh, hm, this needs more specialization...

thomcc · 2022-08-26T20:13:25Z

I'd like to rereview after you make whatever changes are needed, so don't just carry the r+ forward if you don't mind.

thomcc · 2022-08-26T21:53:51Z

Ah, apparently I have to do this to remove it from the queue.

@bors r-

asquared31415 · 2022-09-02T23:33:46Z

I did not mean to close this, whoops

asquared31415 · 2022-09-03T23:40:24Z

@rustbot ready

thomcc · 2022-09-04T18:22:32Z

LGTM (and cleaner now), thanks.

@bors r+

bors · 2022-09-04T18:22:34Z

📌 Commit 80e035c has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-09-04T20:33:53Z

⌛ Testing commit 80e035c with merge 289279d...

bors · 2022-09-04T22:53:52Z

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 289279d to master...

rust-timer · 2022-09-05T01:37:19Z

Finished benchmarking commit (289279d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.6%, 1.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[1.7%, 2.8%]	8
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.7%, 2.8%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

rust-highfive assigned kennytm Jan 29, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2022

This comment has been minimized.
Sign in to view

asquared31415 force-pushed the vec-zero-opts branch from 1e7573d to 652c3fcCompare February 2, 2022 14:47

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2022

rust-highfive assigned m-ou-se and unassigned kennytm Apr 11, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2022

apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 19, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022

rust-highfive assigned thomcc and unassigned m-ou-se Aug 26, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2022

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 26, 2022

asquared31415 force-pushed the vec-zero-opts branch from 652c3fc to 71b721fCompare September 2, 2022 22:54

This comment has been minimized.
Sign in to view

asquared31415 closed this Sep 2, 2022

asquared31415 force-pushed the vec-zero-opts branch from 71b721f to 9ba169aCompare September 2, 2022 23:29

asquared31415 reopened this Sep 2, 2022

This comment has been minimized.
Sign in to view

implement IsZero for Saturating and Wrapping
80e035c

asquared31415 force-pushed the vec-zero-opts branch from 25fe9ed to 80e035cCompare September 2, 2022 23:55

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2022

bors merged commit 289279d into rust-lang:masterSep 4, 2022

rustbot added this to the 1.65.0 milestone Sep 4, 2022

bors mentioned this pull request Sep 4, 2022
Add String::replace_first and String::replace_last#97977
Closed

asquared31415 deleted the vec-zero-opts branch June 22, 2023 01:34

matthiaskrgr mentioned this pull request Sep 3, 2023
ICE: has escaping bound vars, so it cannot be wrapped in a dummy binder.#115517
Closed