Add String::replace_first and String::replace_last - #97977

Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom
WilliamVenner:string_replace_in_place
Closed

Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom
WilliamVenner:string_replace_in_place

Conversation

@WilliamVenner

@WilliamVennerWilliamVenner commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.

@rust-highfive

rust-highfive commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 11, 2022
@rust-highfive

rust-highfive commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2022
@WilliamVenner

WilliamVenner commented Jun 11, 2022

Copy link
Copy Markdown
ContributorAuthor

String::replace_last is currently blocked by #89196 :[

For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.

@WilliamVenner

WilliamVenner commented Jun 11, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot label +T-libs-api -T-libs

@rustbotrustbot added T-libs-api [DEPRECATED; DO NOT USE] and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed the string_replace_in_place branch from 004561b to eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon

JohnCSimon commented Jul 3, 2022•
edited
Loading

Copy link
Copy Markdown

@WilliamVenner
Returning to you to address build failures

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2022
@WilliamVennerWilliamVenner mentioned this pull request Jul 5, 2022
Open
@JohnCSimon

JohnCSimon commented Aug 13, 2022

Copy link
Copy Markdown

@WilliamVenner
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@rustbotrustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Aug 13, 2022
@WilliamVenner

WilliamVenner commented Aug 13, 2022

Copy link
Copy Markdown
ContributorAuthor

??? This is blocked by #98941@JohnCSimon

@JohnCSimonJohnCSimon reopened this Aug 13, 2022
@JohnCSimon

JohnCSimon commented Aug 13, 2022•
edited
Loading

Copy link
Copy Markdown

@WilliamVenner sorry - my mistake, reopened.
Added blocked tag.

@JohnCSimonJohnCSimon added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. labels Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 14, 2022
@bors

bors commented Sep 4, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.

@zachs18

zachs18 commented Apr 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

https://github.com/zachs18/rust/tree/string_replace_in_place_rebase
I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now

@WilliamVenner

WilliamVenner commented Sep 19, 2024

Copy link
Copy Markdown
ContributorAuthor

@zachs18 Thank you 🙂

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner

WilliamVenner commented Sep 19, 2024

Copy link
Copy Markdown
ContributorAuthor

@rustbot label: -S-blocked

@rustbotrustbot removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Sep 19, 2024
@rust-log-analyzer

rust-log-analyzer commented Sep 19, 2024

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 21, 2024
@bors

bors commented Sep 22, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.

@alex-semenyuk

alex-semenyuk commented Nov 5, 2024

Copy link
Copy Markdown
Member

@WilliamVenner
From wg-triage. Do you have any updates on this PR?

@alex-semenyuk

alex-semenyuk commented Dec 14, 2024

Copy link
Copy Markdown
Member

@WilliamVenner
From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.

@zachs18zachs18 mentioned this pull request Dec 14, 2024
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit that referenced this pull request Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add String::replace_first and String::replace_last - #97977
Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Closed
Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Conversation
@WilliamVenner
@WilliamVennerWilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Jun 11, 2022
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 11, 2022
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
String::replace_last is currently blocked by #89196 :[
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@rustbot label +T-libs-api -T-libs
@rustbotrustbot
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon
JohnCSimon
commented
Jul 3, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner

Returning to you to address build failures
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 3, 2022
@WilliamVennerWilliamVenner
mentioned this pull request
Jul 5, 2022

Open

@JohnCSimon
JohnCSimon
commented
Aug 13, 2022

Copy link


Copy Markdown

@WilliamVenner

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.

Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.

Thanks for your contribution.
@rustbot label: +S-inactive
@rustbotrustbot
added
the 
S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
label
Aug 13, 2022
@WilliamVenner
WilliamVenner
commented
Aug 13, 2022

Copy link


Copy Markdown

ContributorAuthor
??? This is blocked by #98941@JohnCSimon
@JohnCSimonJohnCSimon
reopened this
Aug 13, 2022
@JohnCSimon
JohnCSimon
commented
Aug 13, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner sorry - my mistake, reopened.

Added blocked tag.
@JohnCSimonJohnCSimon
added

S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed

S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
labels
Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 14, 2022
@bors
bors
commented
Sep 4, 2022

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.
@zachs18
zachs18
commented
Apr 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase

I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@zachs18 Thank you 🙂
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@rustbot label: -S-blocked
@rustbotrustbot
removed
the 
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Sep 19, 2024
@rust-log-analyzer
rust-log-analyzer
commented
Sep 19, 2024

Copy link


Copy Markdown

Collaborator
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Sep 21, 2024
@bors
bors
commented
Sep 22, 2024

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.
@alex-semenyuk
alex-semenyuk
commented
Nov 5, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Do you have any updates on this PR?
@alex-semenyuk
alex-semenyuk
commented
Dec 14, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.
@zachs18zachs18
mentioned this pull request
Dec 14, 2024
 Merged

Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit
that referenced
this pull request
Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add String::replace_first and String::replace_last - #97977
Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Closed
Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Conversation
@WilliamVenner
@WilliamVennerWilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Jun 11, 2022
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 11, 2022
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
String::replace_last is currently blocked by #89196 :[
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@rustbot label +T-libs-api -T-libs
@rustbotrustbot
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon
JohnCSimon
commented
Jul 3, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner

Returning to you to address build failures
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 3, 2022
@WilliamVennerWilliamVenner
mentioned this pull request
Jul 5, 2022

Open

@JohnCSimon
JohnCSimon
commented
Aug 13, 2022

Copy link


Copy Markdown

@WilliamVenner

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.

Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.

Thanks for your contribution.
@rustbot label: +S-inactive
@rustbotrustbot
added
the 
S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
label
Aug 13, 2022
@WilliamVenner
WilliamVenner
commented
Aug 13, 2022

Copy link


Copy Markdown

ContributorAuthor
??? This is blocked by #98941@JohnCSimon
@JohnCSimonJohnCSimon
reopened this
Aug 13, 2022
@JohnCSimon
JohnCSimon
commented
Aug 13, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner sorry - my mistake, reopened.

Added blocked tag.
@JohnCSimonJohnCSimon
added

S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed

S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
labels
Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 14, 2022
@bors
bors
commented
Sep 4, 2022

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.
@zachs18
zachs18
commented
Apr 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase

I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@zachs18 Thank you 🙂
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@rustbot label: -S-blocked
@rustbotrustbot
removed
the 
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Sep 19, 2024
@rust-log-analyzer
rust-log-analyzer
commented
Sep 19, 2024

Copy link


Copy Markdown

Collaborator
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Sep 21, 2024
@bors
bors
commented
Sep 22, 2024

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.
@alex-semenyuk
alex-semenyuk
commented
Nov 5, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Do you have any updates on this PR?
@alex-semenyuk
alex-semenyuk
commented
Dec 14, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.
@zachs18zachs18
mentioned this pull request
Dec 14, 2024
 Merged

Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit
that referenced
this pull request
Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add String::replace_first and String::replace_last - #97977
Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Closed
Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Conversation
@WilliamVenner
@WilliamVennerWilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Jun 11, 2022
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 11, 2022
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
String::replace_last is currently blocked by #89196 :[
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@rustbot label +T-libs-api -T-libs
@rustbotrustbot
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon
JohnCSimon
commented
Jul 3, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner

Returning to you to address build failures
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 3, 2022
@WilliamVennerWilliamVenner
mentioned this pull request
Jul 5, 2022

Open

@JohnCSimon
JohnCSimon
commented
Aug 13, 2022

Copy link


Copy Markdown

@WilliamVenner

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.

Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.

Thanks for your contribution.
@rustbot label: +S-inactive
@rustbotrustbot
added
the 
S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
label
Aug 13, 2022
@WilliamVenner
WilliamVenner
commented
Aug 13, 2022

Copy link


Copy Markdown

ContributorAuthor
??? This is blocked by #98941@JohnCSimon
@JohnCSimonJohnCSimon
reopened this
Aug 13, 2022
@JohnCSimon
JohnCSimon
commented
Aug 13, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner sorry - my mistake, reopened.

Added blocked tag.
@JohnCSimonJohnCSimon
added

S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed

S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
labels
Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 14, 2022
@bors
bors
commented
Sep 4, 2022

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.
@zachs18
zachs18
commented
Apr 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase

I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@zachs18 Thank you 🙂
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@rustbot label: -S-blocked
@rustbotrustbot
removed
the 
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Sep 19, 2024
@rust-log-analyzer
rust-log-analyzer
commented
Sep 19, 2024

Copy link


Copy Markdown

Collaborator
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Sep 21, 2024
@bors
bors
commented
Sep 22, 2024

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.
@alex-semenyuk
alex-semenyuk
commented
Nov 5, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Do you have any updates on this PR?
@alex-semenyuk
alex-semenyuk
commented
Dec 14, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.
@zachs18zachs18
mentioned this pull request
Dec 14, 2024
 Merged

Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit
that referenced
this pull request
Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add String::replace_first and String::replace_last - #97977
Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Closed
Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Conversation
@WilliamVenner
@WilliamVennerWilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Jun 11, 2022
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 11, 2022
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
String::replace_last is currently blocked by #89196 :[
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@rustbot label +T-libs-api -T-libs
@rustbotrustbot
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon
JohnCSimon
commented
Jul 3, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner

Returning to you to address build failures
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 3, 2022
@WilliamVennerWilliamVenner
mentioned this pull request
Jul 5, 2022

Open

@JohnCSimon
JohnCSimon
commented
Aug 13, 2022

Copy link


Copy Markdown

@WilliamVenner

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.

Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.

Thanks for your contribution.
@rustbot label: +S-inactive
@rustbotrustbot
added
the 
S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
label
Aug 13, 2022
@WilliamVenner
WilliamVenner
commented
Aug 13, 2022

Copy link


Copy Markdown

ContributorAuthor
??? This is blocked by #98941@JohnCSimon
@JohnCSimonJohnCSimon
reopened this
Aug 13, 2022
@JohnCSimon
JohnCSimon
commented
Aug 13, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner sorry - my mistake, reopened.

Added blocked tag.
@JohnCSimonJohnCSimon
added

S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed

S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
labels
Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 14, 2022
@bors
bors
commented
Sep 4, 2022

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.
@zachs18
zachs18
commented
Apr 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase

I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@zachs18 Thank you 🙂
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@rustbot label: -S-blocked
@rustbotrustbot
removed
the 
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Sep 19, 2024
@rust-log-analyzer
rust-log-analyzer
commented
Sep 19, 2024

Copy link


Copy Markdown

Collaborator
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Sep 21, 2024
@bors
bors
commented
Sep 22, 2024

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.
@alex-semenyuk
alex-semenyuk
commented
Nov 5, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Do you have any updates on this PR?
@alex-semenyuk
alex-semenyuk
commented
Dec 14, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.
@zachs18zachs18
mentioned this pull request
Dec 14, 2024
 Merged

Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit
that referenced
this pull request
Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add String::replace_first and String::replace_last - #97977
Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Closed
Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Conversation
@WilliamVenner
@WilliamVennerWilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Jun 11, 2022
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 11, 2022
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
String::replace_last is currently blocked by #89196 :[
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@rustbot label +T-libs-api -T-libs
@rustbotrustbot
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon
JohnCSimon
commented
Jul 3, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner

Returning to you to address build failures
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 3, 2022
@WilliamVennerWilliamVenner
mentioned this pull request
Jul 5, 2022

Open

@JohnCSimon
JohnCSimon
commented
Aug 13, 2022

Copy link


Copy Markdown

@WilliamVenner

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.

Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.

Thanks for your contribution.
@rustbot label: +S-inactive
@rustbotrustbot
added
the 
S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
label
Aug 13, 2022
@WilliamVenner
WilliamVenner
commented
Aug 13, 2022

Copy link


Copy Markdown

ContributorAuthor
??? This is blocked by #98941@JohnCSimon
@JohnCSimonJohnCSimon
reopened this
Aug 13, 2022
@JohnCSimon
JohnCSimon
commented
Aug 13, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner sorry - my mistake, reopened.

Added blocked tag.
@JohnCSimonJohnCSimon
added

S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed

S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
labels
Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 14, 2022
@bors
bors
commented
Sep 4, 2022

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.
@zachs18
zachs18
commented
Apr 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase

I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@zachs18 Thank you 🙂
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@rustbot label: -S-blocked
@rustbotrustbot
removed
the 
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Sep 19, 2024
@rust-log-analyzer
rust-log-analyzer
commented
Sep 19, 2024

Copy link


Copy Markdown

Collaborator
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Sep 21, 2024
@bors
bors
commented
Sep 22, 2024

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.
@alex-semenyuk
alex-semenyuk
commented
Nov 5, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Do you have any updates on this PR?
@alex-semenyuk
alex-semenyuk
commented
Dec 14, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.
@zachs18zachs18
mentioned this pull request
Dec 14, 2024
 Merged

Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit
that referenced
this pull request
Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add String::replace_first and String::replace_last - #97977
Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Closed
Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Conversation
@WilliamVenner
@WilliamVennerWilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Jun 11, 2022
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 11, 2022
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
String::replace_last is currently blocked by #89196 :[
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@rustbot label +T-libs-api -T-libs
@rustbotrustbot
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon
JohnCSimon
commented
Jul 3, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner

Returning to you to address build failures
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 3, 2022
@WilliamVennerWilliamVenner
mentioned this pull request
Jul 5, 2022

Open

@JohnCSimon
JohnCSimon
commented
Aug 13, 2022

Copy link


Copy Markdown

@WilliamVenner

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.

Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.

Thanks for your contribution.
@rustbot label: +S-inactive
@rustbotrustbot
added
the 
S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
label
Aug 13, 2022
@WilliamVenner
WilliamVenner
commented
Aug 13, 2022

Copy link


Copy Markdown

ContributorAuthor
??? This is blocked by #98941@JohnCSimon
@JohnCSimonJohnCSimon
reopened this
Aug 13, 2022
@JohnCSimon
JohnCSimon
commented
Aug 13, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner sorry - my mistake, reopened.

Added blocked tag.
@JohnCSimonJohnCSimon
added

S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed

S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
labels
Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 14, 2022
@bors
bors
commented
Sep 4, 2022

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.
@zachs18
zachs18
commented
Apr 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase

I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@zachs18 Thank you 🙂
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@rustbot label: -S-blocked
@rustbotrustbot
removed
the 
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Sep 19, 2024
@rust-log-analyzer
rust-log-analyzer
commented
Sep 19, 2024

Copy link


Copy Markdown

Collaborator
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Sep 21, 2024
@bors
bors
commented
Sep 22, 2024

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.
@alex-semenyuk
alex-semenyuk
commented
Nov 5, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Do you have any updates on this PR?
@alex-semenyuk
alex-semenyuk
commented
Dec 14, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.
@zachs18zachs18
mentioned this pull request
Dec 14, 2024
 Merged

Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit
that referenced
this pull request
Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add String::replace_first and String::replace_last - #97977
Closed
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Closed
Add String::replace_first and String::replace_last#97977
WilliamVenner wants to merge 5 commits into
rust-lang:masterfrom 
WilliamVenner:string_replace_in_place
Conversation
@WilliamVenner
@WilliamVennerWilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Convenience methods that use match_indices and replace_range to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of Vec::splice) allows.
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Jun 11, 2022
@rust-highfive
rust-highfive
commented
Jun 11, 2022

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.
Please see the contribution instructions for more information.
@rust-highfiverust-highfive
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 11, 2022
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
String::replace_last is currently blocked by #89196 :[
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved.
@WilliamVenner
WilliamVenner
commented
Jun 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@rustbot label +T-libs-api -T-libs
@rustbotrustbot
added

T-libs-api
[DEPRECATED; DO NOT USE]
and removed

T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVennerforce-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3cCompareJune 11, 2022 02:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JohnCSimon
JohnCSimon
commented
Jul 3, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner

Returning to you to address build failures
FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.
@rustbot author
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 3, 2022
@WilliamVennerWilliamVenner
mentioned this pull request
Jul 5, 2022

Open

@JohnCSimon
JohnCSimon
commented
Aug 13, 2022

Copy link


Copy Markdown

@WilliamVenner

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.

Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.

Thanks for your contribution.
@rustbot label: +S-inactive
@rustbotrustbot
added
the 
S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
label
Aug 13, 2022
@WilliamVenner
WilliamVenner
commented
Aug 13, 2022

Copy link


Copy Markdown

ContributorAuthor
??? This is blocked by #98941@JohnCSimon
@JohnCSimonJohnCSimon
reopened this
Aug 13, 2022
@JohnCSimon
JohnCSimon
commented
Aug 13, 2022•

edited

Loading

Copy link


Copy Markdown

@WilliamVenner sorry - my mistake, reopened.

Added blocked tag.
@JohnCSimonJohnCSimon
added

S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed

S-inactive
Status: Inactive and waiting on the author. This is often applied to closed PRs.
labels
Aug 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPCDylan-DPC
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 14, 2022
@bors
bors
commented
Sep 4, 2022

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts.
@zachs18
zachs18
commented
Apr 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase

I have a branch with this PR's changes rebased onto current master that also somewhat avoids the blocking issue by hardcoding the doclink to ../../std/primitive.str.html#method.replacen instead of using intra-doc links. The effect of this is that the doclink is only broken if you build alloc's docs and notstd's docs. There is precedent for this e.g. in core::hint::spin_loop which links to std::thread::yield_now
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@zachs18 Thank you 🙂
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WilliamVenner
WilliamVenner
commented
Sep 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@rustbot label: -S-blocked
@rustbotrustbot
removed
the 
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
label
Sep 19, 2024
@rust-log-analyzer
rust-log-analyzer
commented
Sep 19, 2024

Copy link


Copy Markdown

Collaborator
The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)
Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:30ca74372d8b771363f68f939a58b017a592fae4f69398600dc51145997160f03e9652051f957840c41898984a88855e9757fa23464703a5a4ba21316ddebb04:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.73s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [run-make] tests/run-make/alloc-no-oom-handling stdout ----
error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" && env -u RUSTFLAGS AR="ar" CC="cc" CC_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" CXX="c++" CXX_DEFAULT_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64" HOST_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/usr/lib/llvm-18/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen codegentypes core coroutines coverage debuginfobtf debuginfocodeview debuginfodwarf debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser textapi textapibinaryreader transformutils ve veasmparser vecodegen vectorize vedesc vedisassembler veinfo webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/usr/lib/llvm-18/bin/FileCheck" NODE="/usr/bin/node" PYTHON="/usr/bin/python3" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="x86_64-unknown-linux-gnu" TARGET_RPATH_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" TARGET_RPATH_ENV="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake"
--- stderr -------------------------------
command failed at line 14
command failed at line 14
Command { cmd: LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/alloc-no-oom-handling/rmake_out" "--edition" "2021" "-Dwarnings" "--crate-type" "rlib" "/checkout/library/alloc/src/lib.rs" "--cfg" "no_global_oom_handling", stdin_buf: None, stdin: None, stdout: None, stderr: None, drop_bomb: DropBomb { command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc", defused: true, armed_location: Location { file: "/checkout/tests/run-make/alloc-no-oom-handling/rmake.rs", line: 8, col: 5 } }, already_executed: true }
output status: `exit status: 1`
=== STDOUT ===
=== STDERR ===
error[E0635]: unknown feature `string_replace_in_place`

@Dylan-DPCDylan-DPC
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Sep 21, 2024
@bors
bors
commented
Sep 22, 2024

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.
@alex-semenyuk
alex-semenyuk
commented
Nov 5, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Do you have any updates on this PR?
@alex-semenyuk
alex-semenyuk
commented
Dec 14, 2024

Copy link


Copy Markdown

Member
@WilliamVenner

From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.
@zachs18zachs18
mentioned this pull request
Dec 14, 2024
 Merged

Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
@Zalathar
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
eaf3cac
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
rust-timer added a commit
that referenced
this pull request
Oct 23, 2025
@rust-timer
Unrolled build for#134316
b14dfec
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of #97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
8ea4800
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
dcb5761
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
83461c8
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@kennytmkennytm

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libs-api[DEPRECATED; DO NOT USE]

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

10 participants

@WilliamVenner@rust-highfive@rust-log-analyzer@JohnCSimon@bors@zachs18@alex-semenyuk@kennytm@rustbot@Dylan-DPC