Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #94199
Closed
Manishearth wants to merge 21 commits into
Closed
Conversation
This is already handled by supported_types().
The previous approach of checking for the reserve-r9 target feature didn't actually work because LLVM only sets this feature very late when initializing the per-function subtarget.
Checking of asm! register operands now properly takes function attributes such as #[target_feature] and #[instruction_set] into account.
…me in run_cargo Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
Some improvements to the async docs The goal here is to make the docs overall a little bit more comprehensive and add more links between the things. One thing that's not working yet is the links to the keywords. Somehow I couldn't get them to work. r? ``@GuillaumeGomez`` do you know how I could get the keyword links to work?
Ensure stability directives are checked in all cases Split off rust-lang#93017 Stability and deprecation were not checked in all cases, for instance if a type error happened. This PR moves the check earlier in the pipeline to ensure the errors are emitted in all cases. r? ``@lcnr``
Gracefully handle non-UTF-8 string slices when pretty printing Fixesrust-lang#78520.
Fix several asm! related issues This is a combination of several fixes, each split into a separate commit. Splitting these into PRs is not practical since they conflict with each other. Fixesrust-lang#92378Fixesrust-lang#85247 r? ``@nagisa``
…RalfJung Implement LowerHex on Scalar to clean up their display in rustdoc Follow-up of rust-lang#94091. r? ``@RalfJung``
…crum Use Metadata::modified instead of FileTime::from_last_modification_ti… …me in run_cargo Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
Manishearth
commented
Feb 20, 2022
MemberAuthor
@bors r+ p=5 rollup=never |
bors
commented
Feb 20, 2022
Collaborator
📌 Commit b172749 has been approved by |
bors
commented
Feb 20, 2022
Collaborator
⌛ Testing commit b172749 with merge a472e5f46958f47653eca5585b4c8cb7e757c23c... |
bors
commented
Feb 21, 2022
Collaborator
💔 Test failed - checks-actions |
Manishearth
commented
Feb 21, 2022
MemberAuthor
@bors r+ |
bors
commented
Feb 21, 2022
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Feb 21, 2022
Collaborator
📌 Commit b172749 has been approved by |
rust-log-analyzer
commented
Feb 21, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-log-analyzer
commented
Feb 21, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup