Uh oh!
There was an error while loading. Please reload this page.
Give more details in Display for hir::Target - #95108
Merged
Merged
Conversation
Made because I was making a code change and got a very confusing "should be applied to a method, not a method" error. ``` error[E0718]: `into_try_type` language item must be applied to a method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a method, not a method ```
rust-highfive
commented
Mar 19, 2022
Contributor
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
Dylan-DPC
commented
Mar 19, 2022
Member
r? @Dylan-DPC |
Dylan-DPC
commented
Mar 19, 2022
Member
@bors r+ rollup |
bors
commented
Mar 19, 2022
Collaborator
📌 Commit 1338a45 has been approved by |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 19, 2022
…Dylan-DPC Give more details in `Display` for `hir::Target` Made because I was making a code change and got a very confusing "should be applied to a method, not a method" error. ``` error[E0718]: `into_try_type` language item must be applied to a method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a method, not a method ``` With this change the error is more actionable ``` error[E0718]: `into_try_type` language item must be applied to a required trait method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a required trait method, not a provided trait method ```
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 19, 2022
…Dylan-DPC Give more details in `Display` for `hir::Target` Made because I was making a code change and got a very confusing "should be applied to a method, not a method" error. ``` error[E0718]: `into_try_type` language item must be applied to a method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a method, not a method ``` With this change the error is more actionable ``` error[E0718]: `into_try_type` language item must be applied to a required trait method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a required trait method, not a provided trait method ```
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#94749 (remove_dir_all: use fallback implementation on Miri) - rust-lang#94948 (Fix diagnostics for `#![feature(deprecated_suggestion)]`) - rust-lang#94989 (Add Stream alias for AsyncIterator) - rust-lang#95108 (Give more details in `Display` for `hir::Target`) - rust-lang#95110 (Provide more useful documentation of conversion methods) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made because I was making a code change and got a very confusing "should be applied to a method, not a method" error.
With this change the error is more actionable