Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #95133
Merged
Merged
Conversation
I thought that the documentation for these methods needed to be a bit more explanatory for new users. For advanced users, the comments are relatively unnecessary. I think it would be useful to explain precisely what the method does. As a new user, when you see the `into` method, where the type is inferred, if you are new you don't even know what you convert to, because it is implicit. I believe this can help new users understand.
Made because I was making a code change and got a very confusing "should be applied to a method, not a method" error. ``` error[E0718]: `into_try_type` language item must be applied to a method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a method, not a method ```
…iper remove_dir_all: use fallback implementation on Miri Fixesrust-lang/miri#1966 The new implementation requires `openat`, `unlinkat`, and `fdopendir`. These cannot easily be shimmed in Miri since libstd does not expose APIs corresponding to them. So for now it is probably easiest to just use the fallback code in Miri. Nobody should run Miri as root anyway...
Fix diagnostics for `#![feature(deprecated_suggestion)]` Follow up from rust-lang#94635, where I missed a couple things.
…an-DPC Add Stream alias for AsyncIterator Fixesrust-lang#94965
…Dylan-DPC Give more details in `Display` for `hir::Target` Made because I was making a code change and got a very confusing "should be applied to a method, not a method" error. ``` error[E0718]: `into_try_type` language item must be applied to a method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a method, not a method ``` With this change the error is more actionable ``` error[E0718]: `into_try_type` language item must be applied to a required trait method --> library\core\src\ops\try_trait.rs:352:32 | 352 | #[cfg_attr(not(bootstrap), lang = "into_try_type")] | ^^^^^^^^^^^^^^^^^^^^^^ attribute should be applied to a required trait method, not a provided trait method ```
Provide more useful documentation of conversion methods I thought that the documentation for these methods needed to be a bit more explanatory for new users. For advanced users, the comments are relatively unnecessary. I think it would be useful to explain precisely what the method does. As a new user, when you see the `into` method, where the type is inferred, if you are new you don't even know what you convert to, because it is implicit. I believe this can help new users understand.
matthiaskrgr
commented
Mar 20, 2022
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Mar 20, 2022
Collaborator
📌 Commit 9725caf has been approved by |
bors
commented
Mar 20, 2022
Collaborator
bors
commented
Mar 20, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Mar 20, 2022
Collaborator
Finished benchmarking commit (3b84829): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#![feature(deprecated_suggestion)]#94948 (Fix diagnostics for#![feature(deprecated_suggestion)])Displayforhir::Target#95108 (Give more details inDisplayforhir::Target)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup