Skip to content

Fix snapshot --bless not working anymore in htmldocck - #96143

Merged
bors merged 1 commit into
rust-lang:masterfrom
Urgau:rustdoc-fix-snapshot-bless
Apr 18, 2022
Merged

Fix snapshot --bless not working anymore in htmldocck#96143
bors merged 1 commit into
rust-lang:masterfrom
Urgau:rustdoc-fix-snapshot-bless

Conversation

@Urgau

Copy link
Copy Markdown
Member

I broke it in #95933

r? @GuillaumeGomez

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 17, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2022
@UrgauUrgau changed the title Fix --bless not working anymore in htmldocckFix snapshot --bless not working anymore in htmldocckApr 17, 2022
@GuillaumeGomez

Copy link
Copy Markdown
Member

@bors: r+

@GuillaumeGomez

Copy link
Copy Markdown
Member

Seems like it didn't work... Let's try again!

@bors: r+

@bors

bors commented Apr 17, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 06ec80a has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 17, 2022
…=GuillaumeGomez
Fix snapshot --bless not working anymore in htmldocck
I broke it in rust-lang#95933
r? `@GuillaumeGomez`
@Dylan-DPCDylan-DPC mentioned this pull request Apr 17, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 18, 2022
…=GuillaumeGomez
Fix snapshot --bless not working anymore in htmldocck
I broke it in rust-lang#95933
r? ``@GuillaumeGomez``
@Dylan-DPCDylan-DPC mentioned this pull request Apr 18, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Apr 18, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2022
Rollup of 5 pull requests
Successful merges:
- rust-lang#96032 (Update books)
- rust-lang#96136 (Reword clarification on lifetime for ptr->ref safety docs)
- rust-lang#96143 (Fix snapshot --bless not working anymore in htmldocck)
- rust-lang#96148 (Use revisions instead of nll compare mode for `/self/` ui tests)
- rust-lang#96156 (Replace u8to64_le macro with u64::from_le_bytes)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9c1c8b2 into rust-lang:masterApr 18, 2022
@rustbotrustbot added this to the 1.62.0 milestone Apr 18, 2022
@Urgau
Urgau deleted the rustdoc-fix-snapshot-bless branch May 5, 2023 16:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Urgau@GuillaumeGomez@bors@rust-highfive@rustbot