Uh oh!
There was an error while loading. Please reload this page.
Use revisions instead of nll compare mode for /self/ ui tests - #96148
Merged
Conversation
jackh726
approved these changes
Apr 17, 2022
jackh726
left a comment
Member
There was a problem hiding this comment.
LGTM, other than needing to file an issue for the note and suggestion (it happens in several of these tests).
r=me after that
| @@ -13,7 +13,7 @@ LL | fn a<'a>(self: Pin<&'a Foo>, f: &'a Foo) -> &Foo { f } | |||
| | ++++ ++ ++ | |||
| error[E0623]: lifetime mismatch | |||
| --> $DIR/arbitrary_self_types_pin_lifetime_mismatch.rs:8:76 | |||
Member
There was a problem hiding this comment.
We lose the suggestion above. Can you file an issue for this?
marmeladema
commented
Apr 17, 2022
ContributorAuthor
@jackh726 done! |
jackh726
commented
Apr 17, 2022
Member
@bors r+ |
bors
commented
Apr 17, 2022
Collaborator
📌 Commit e818f45 has been approved by |
jackh726
commented
Apr 17, 2022
Member
@bors rollup |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 18, 2022
…ackh726 Use revisions instead of nll compare mode for `/self/` ui tests r? `@jackh726`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#96032 (Update books) - rust-lang#96136 (Reword clarification on lifetime for ptr->ref safety docs) - rust-lang#96143 (Fix snapshot --bless not working anymore in htmldocck) - rust-lang#96148 (Use revisions instead of nll compare mode for `/self/` ui tests) - rust-lang#96156 (Replace u8to64_le macro with u64::from_le_bytes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @jackh726