Uh oh!
There was an error while loading. Please reload this page.
Remove unused macro rules - #96149
Merged
Merged
Conversation
rust-highfive
commented
Apr 17, 2022
Contributor
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
commented
Apr 17, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Apr 17, 2022
Contributor
|
est31force-pushed
the
remove_unused_macro_matchers
branch
3 times, most recently
from
April 17, 2022 20:56
bebd139 to
9a915bcCompareest31force-pushed
the
remove_unused_macro_matchers
branch
from
April 18, 2022 21:28
9a915bc to
3c1e166Compareest31
commented
Apr 24, 2022
MemberAuthor
This is a prerequisite for #96150. r? @petrochenkov |
petrochenkov
commented
Apr 25, 2022
Contributor
@bors r+ rollup |
bors
commented
Apr 25, 2022
Collaborator
📌 Commit 3c1e166 has been approved by |
compiler-errors added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 25, 2022
… r=petrochenkov Remove unused macro rules Removes rules of internal macros that weren't triggered.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#90312 (Fix some confusing wording and improve slice-search-related docs) - rust-lang#96149 (Remove unused macro rules) - rust-lang#96279 (rustdoc: Remove .woff font files) - rust-lang#96355 (Better handle too many `#` recovery in raw str) - rust-lang#96379 (delay bug when adjusting `NeverToAny` twice during diagnostic code) - rust-lang#96384 (do not consider two extern types to be similar) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 26, 2022
Implement a lint to warn about unused macro rules This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros. ```rust macro_rules! unused_empty { (hello) => { println!("Hello, world!") }; () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used } fn main() { unused_empty!(hello); } ``` Builds upon ~~(and currently integrates)~~ rust-lang#96149 and rust-lang#96156. Fixesrust-lang#73576
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 6, 2022
…enkov Implement a lint to warn about unused macro rules This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros. ```rust macro_rules! unused_empty { (hello) => { println!("Hello, world!") }; () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used } fn main() { unused_empty!(hello); } ``` Builds upon rust-lang#96149 and rust-lang#96156. Fixesrust-lang#73576
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 6, 2022
…enkov Implement a lint to warn about unused macro rules This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros. ```rust macro_rules! unused_empty { (hello) => { println!("Hello, world!") }; () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used } fn main() { unused_empty!(hello); } ``` Builds upon rust-lang#96149 and rust-lang#96156. Fixesrust-lang#73576
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2022
Implement a lint to warn about unused macro rules This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros. ```rust macro_rules! unused_empty { (hello) => { println!("Hello, world!") }; () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used } fn main() { unused_empty!(hello); } ``` Builds upon rust-lang#96149 and rust-lang#96156. Fixesrust-lang#73576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes rules of internal macros that weren't triggered.