Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #96398
Closed
compiler-errors wants to merge 12 commits into
Closed
Conversation
Point at all the unnecessary trailing `#`. Better handle interaction with outer attributes when `;` is missing. Fixrust-lang#95030.
Fix some confusing wording and improve slice-search-related docs This adds more links between `contains` and `binary_search` because I do think they have some relevant connections. If your (big) slice happens to be sorted and you know it, surely you should be using `[3; 100].binary_search(&5).is_ok()` over `[3; 100].contains(&5)`? This also fixes the confusing "searches this sorted X" wording which just sounds really weird because it doesn't know whether it's actually sorted. It should be but it may not be. The new wording should make it clearer that you will probably want to sort it and in the same sentence it also mentions the related function `contains`. Similarly, this mentions `binary_search` on `contains`' docs. This also fixes some other minor stuff and inconsistencies.
… r=petrochenkov Remove unused macro rules Removes rules of internal macros that weren't triggered.
…rors Better handle too many `#` recovery in raw str Point at all the unnecessary trailing `#`. Better handle interaction with outer attributes when `;` is missing. Fixrust-lang#95030.
…t, r=oli-obk Suggest calling method on nested field when struct is missing method Similar to the suggestion to change `x.field` to `x.nested.field`, implement a similar suggestion for when `x.method()` should be replaced with `x.nested.method()`.
…-errors delay bug when adjusting `NeverToAny` twice during diagnostic code Addresses Issue 96335 (rust-lang#96335) by using `delay_span_bug` instead of an assert and returning an error type from `check_expr_meets_expectation_or_error`. Fixesrust-lang#96335
…er-errors do not consider two extern types to be similar
compiler-errors
commented
Apr 25, 2022
ContributorAuthor
@bors r+ rollup=never p=6 |
bors
commented
Apr 25, 2022
Collaborator
📌 Commit 0f11c81 has been approved by |
bors
commented
Apr 25, 2022
Collaborator
⌛ Testing commit 0f11c81 with merge c7d940da7f203588f1267f031b51662dfa92689a... |
bors
commented
Apr 25, 2022
Collaborator
💔 Test failed - checks-actions |
compiler-errors
commented
Apr 25, 2022
ContributorAuthor
@bors retry timeout in rustdoc test? |
This comment was marked as outdated.
This comment was marked as outdated.
bors
commented
Apr 25, 2022
Collaborator
⌛ Testing commit 0f11c81 with merge 5820f313904c378dbd8eee9b367da8e08ff7d18b... |
rust-log-analyzer
commented
Apr 25, 2022
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Apr 25, 2022
Collaborator
💔 Test failed - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#recovery in raw str #96355 (Better handle too many#recovery in raw str)NeverToAnytwice during diagnostic code #96379 (delay bug when adjustingNeverToAnytwice during diagnostic code)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup