Uh oh!
There was an error while loading. Please reload this page.
Clarify slice and Vec iteration order - #97087
Merged
Merged
Conversation
While already being inferable from the doc examples, it wasn't fully specified. This is the only logical way to do a slice iterator.
rust-highfive
commented
May 16, 2022
Contributor
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
commented
May 16, 2022
Contributor
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
Noratrieb
commented
May 16, 2022
MemberAuthor
r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs |
dtolnay
commented
May 22, 2022
Member
@bors r+ rollup |
bors
commented
May 22, 2022
Collaborator
📌 Commit 4a22148 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97087 (Clarify slice and Vec iteration order) - rust-lang#97254 (Remove feature: `crate` visibility modifier) - rust-lang#97271 (Add regression test for rust-lang#91949) - rust-lang#97294 (std::time : fix variable name in the doc) - rust-lang#97303 (Fix some typos in arg checking algorithm) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While already being inferable from the doc examples, it wasn't fully specified. This is the only logical way to do a slice iterator, so I think this should be uncontroversial. It also improves the
Vec::into_iterexample to better show the order and that the iterator returns owned values.