Skip to content

Fix some typos in arg checking algorithm - #97303

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:arg-typos
May 23, 2022
Merged

Fix some typos in arg checking algorithm#97303
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:arg-typos

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Fixes#97197

Also fixes a typo where if we're missing args A, B, C, we actually say A, B, B

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2022
@compiler-errors

Copy link
Copy Markdown
ContributorAuthor

r? @jackh726 since you wrote this code I think

Also nominating for beta backport because this hit beta apparently, see #97197 .

@rust-highfiverust-highfive assigned jackh726 and unassigned nagisaMay 23, 2022
@compiler-errorscompiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 23, 2022
@jackh726

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented May 23, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 21a7b4c has been approved by jackh726

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2022
@Dylan-DPCDylan-DPC mentioned this pull request May 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2022
Rollup of 5 pull requests
Successful merges:
- rust-lang#97087 (Clarify slice and Vec iteration order)
- rust-lang#97254 (Remove feature: `crate` visibility modifier)
- rust-lang#97271 (Add regression test for rust-lang#91949)
- rust-lang#97294 (std::time : fix variable name in the doc)
- rust-lang#97303 (Fix some typos in arg checking algorithm)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b5ff4ad into rust-lang:masterMay 23, 2022
@rustbotrustbot added this to the 1.63.0 milestone May 23, 2022
@apiraino

Copy link
Copy Markdown
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 26, 2022
@ehussehuss modified the milestones: 1.63.0, 1.62.0Jun 1, 2022
ehuss pushed a commit to ehuss/rust that referenced this pull request Jun 1, 2022
Fix some typos in arg checking algorithm
Fixesrust-lang#97197
Also fixes a typo where if we're missing args A, B, C, we actually say A, B, B
@ehussehuss mentioned this pull request Jun 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2022
[beta] Beta backports
* Allow the unused_macro_rules lint for now rust-lang#97032
* Fix some typos in arg checking algorithm rust-lang#97303
* rustc: Fix ICE in native library error reporting rust-lang#97328
* Cargo:
* Fix `cargo publish -p spec` rust-lang/cargo#10707
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 23, 2022
@compiler-errors
compiler-errors deleted the arg-typos branch August 11, 2023 19:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Index out of bounds while checking function arguments

8 participants

@compiler-errors@rust-highfive@jackh726@bors@apiraino@ehuss@nagisa@rustbot