Uh oh!
There was an error while loading. Please reload this page.
Add new eslint rule to prevent whitespace before function call paren - #97286
Merged
Conversation
rust-highfive
commented
May 22, 2022
Contributor
Some changes occurred in HTML/CSS/JS. |
notriddle
commented
May 22, 2022
Contributor
I guess. Maybe you could make your PRs with more lint additions at once? Or is this expected to be the last one? |
GuillaumeGomez
commented
May 23, 2022
MemberAuthor
I'm adding them slowly to make reviews simpler. I tend to add multiple at once when they have no impact on code. I go through the eslint lint list and check them. I can make bigger PRs if you're okay with it though. |
notriddle
commented
May 23, 2022
Contributor
It’s okay. I just noticed that a few of these didn’t have any impact on code, so they definitely could’ve been merged all at once. @bors r+ rollup=always |
bors
commented
May 23, 2022
Collaborator
📌 Commit 399299f has been approved by |
GuillaumeGomez
commented
May 23, 2022
MemberAuthor
Okay, I'll group more of them at once so there are less PRs. |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#96129 (Document rounding for floating-point primitive operations and string parsing) - rust-lang#97286 (Add new eslint rule to prevent whitespace before function call paren) - rust-lang#97292 (Lifetime variance fixes for rustc) - rust-lang#97309 (Add some regression tests for rust-lang#90400) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It prevents
foo ()basically. :)r? @notriddle