Uh oh!
There was an error while loading. Please reload this page.
Rollup of 4 pull requests - #97315
Merged
Merged
Conversation
State that the four primitive operations honour IEEE 754 roundTiesToEven. Documenting under "Primitive Type f32"; f64 refers to that.
…Dylan-DPC Document rounding for floating-point primitive operations and string parsing The docs for floating point don't have much to say at present about either the precision of their results or rounding behaviour. As I understand it[^1][^2], Rust doesn't support operating with non-default rounding directions, so we need only describe roundTiesToEven. [^1]: rust-lang#41753 (comment) [^2]: llvm/llvm-project#8472 (comment) This PR makes a start by documenting that for primitive operations and `from_str()`.
…otriddle Add new eslint rule to prevent whitespace before function call paren It prevents `foo ()` basically. :) r? `@notriddle`
…idtwco Lifetime variance fixes for rustc rust-lang#97287 migrates rustc to a `Ty` type that is invariant over its lifetime `'tcx`, so I need to fix a bunch of places that assume that `Ty<'a>` and `Ty<'b>` can be unified by shortening both to some common lifetime. This is doable, since many lifetimes are already `'tcx`, so all this PR does is be a bit more explicit that elided lifetimes are actually `'tcx`. Split out from rust-lang#97287 so the compiler team can review independently.
…rrors Add some regression tests for rust-lang#90400 This adds two regression tests taken from rust-lang#90400 (comment). Note that we cannot close the issue right now as the [original code](rust-lang#90400 (comment)) still triggers an ICE. r? `@compiler-errors`
Dylan-DPC
commented
May 23, 2022
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
May 23, 2022
Collaborator
📌 Commit cf7e396 has been approved by |
bors
commented
May 23, 2022
Collaborator
bors
commented
May 23, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
May 23, 2022
Collaborator
Finished benchmarking commit (7f997f5): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup