Uh oh!
There was an error while loading. Please reload this page.
Lifetime variance fixes for rustdoc - #97288
Merged
Merged
Conversation
rust-highfive
commented
May 22, 2022
Contributor
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
compiler-errorsforce-pushed
the
tcxify-rustdoc
branch
from
May 22, 2022 21:16
b2ae074 to
e81578eComparecompiler-errorsforce-pushed
the
tcxify-rustdoc
branch
from
May 22, 2022 21:22
e81578e to
b2a95cbCompareGuillaumeGomez
approved these changes
May 24, 2022
Dylan-DPC
commented
May 24, 2022
Member
@bors r+ rollup |
bors
commented
May 24, 2022
Collaborator
📌 Commit b2a95cb has been approved by |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 24, 2022
…ylan-DPC Lifetime variance fixes for rustdoc rust-lang#97287 migrates rustc to a `Ty` type that is invariant over its lifetime `'tcx`, so I need to fix a bunch of places that assume that `Ty<'a>` and `Ty<'b>` can be unified by shortening both to some common lifetime. This is doable, since everything is already `'tcx`, so all this PR does is be a bit more explicit that elided lifetimes are actually `'tcx`. Split out from rust-lang#97287 so the rustdoc team can review independently.
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 24, 2022
…ylan-DPC Lifetime variance fixes for rustdoc rust-lang#97287 migrates rustc to a `Ty` type that is invariant over its lifetime `'tcx`, so I need to fix a bunch of places that assume that `Ty<'a>` and `Ty<'b>` can be unified by shortening both to some common lifetime. This is doable, since everything is already `'tcx`, so all this PR does is be a bit more explicit that elided lifetimes are actually `'tcx`. Split out from rust-lang#97287 so the rustdoc team can review independently.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 24, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#97288 (Lifetime variance fixes for rustdoc) - rust-lang#97298 (Parse expression after `else` as a condition if followed by `{`) - rust-lang#97308 (Stabilize `cell_filter_map`) - rust-lang#97321 (explain how to turn integers into fn ptrs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#97287 migrates rustc to a
Tytype that is invariant over its lifetime'tcx, so I need to fix a bunch of places that assume thatTy<'a>andTy<'b>can be unified by shortening both to some common lifetime.This is doable, since everything is already
'tcx, so all this PR does is be a bit more explicit that elided lifetimes are actually'tcx.Split out from #97287 so the rustdoc team can review independently.