Uh oh!
There was an error while loading. Please reload this page.
Rollup of 4 pull requests - #97356
Merged
Merged
Conversation
(with an intermediate raw ptr, not a direct transmute)
…ylan-DPC Lifetime variance fixes for rustdoc rust-lang#97287 migrates rustc to a `Ty` type that is invariant over its lifetime `'tcx`, so I need to fix a bunch of places that assume that `Ty<'a>` and `Ty<'b>` can be unified by shortening both to some common lifetime. This is doable, since everything is already `'tcx`, so all this PR does is be a bit more explicit that elided lifetimes are actually `'tcx`. Split out from rust-lang#97287 so the rustdoc team can review independently.
…, r=davidtwco
Parse expression after `else` as a condition if followed by `{`
Fixesrust-lang#49361.
Two things:
1. This wording needs help. I can never find a natural/intuitive phrasing when I write diagnostics 😅
2. Do we even want to show the "wrap in braces" case? I would assume most of the time the "add an `if`" case is the right one.…, r=Mark-Simulacrum Stabilize `cell_filter_map` FCP has been completed: rust-lang#81061 (comment)Closesrust-lang#81061
explain how to turn integers into fn ptrs (with an intermediate raw ptr, not a direct transmute) Direct int2ptr transmute, under the semantics I am imagining, will produce a ptr with "invalid" provenance that is invalid to deref or call. We cannot give it the same semantics as int2ptr casts since those do [something complicated](https://www.ralfj.de/blog/2022/04/11/provenance-exposed.html). To my great surprise, that is already what the example in the `transmute` docs does. :) I still added a comment to say that that part is important, and I added a section explicitly talking about this to the `fn()` type docs. With rust-lang/miri#2151, Miri will start complaining about direct int-to-fnptr transmutes (in the sense that it is UB to call the resulting pointer).
Dylan-DPC
commented
May 24, 2022
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
May 24, 2022
Collaborator
📌 Commit 4bd4018 has been approved by |
bors
commented
May 24, 2022
Collaborator
bors
commented
May 24, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
May 24, 2022
Collaborator
Finished benchmarking commit (fa70b89): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
elseas a condition if followed by{#97298 (Parse expression afterelseas a condition if followed by{)cell_filter_map#97308 (Stabilizecell_filter_map)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup