Rewrite LLVM's archive writer in Rust by bjorn3 · Pull Request #97485 · rust-lang/rust

bjorn3 · 2022-05-28T13:20:09Z

This allows it to be used by other codegen backends.

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1155

rust-highfive · 2022-05-28T13:20:12Z

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

bjorn3 · 2022-05-28T13:20:29Z

@bors try @rust-timer queue

rust-timer · 2022-05-28T13:20:30Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-05-28T13:20:36Z

⌛ Trying commit eac8f47a8b8976e66336780f2caa5bb880bd89bc with merge 0112e87814d8082045abebb2531cc885650f2d3e...

bors · 2022-05-28T14:52:31Z

☀️ Try build successful - checks-actions
Build commit: 0112e87814d8082045abebb2531cc885650f2d3e (0112e87814d8082045abebb2531cc885650f2d3e)

rust-timer · 2022-05-28T14:52:33Z

Queued 0112e87814d8082045abebb2531cc885650f2d3e with parent 19abca1, future comparison URL.

rust-timer · 2022-05-28T19:55:28Z

Finished benchmarking commit (0112e87814d8082045abebb2531cc885650f2d3e): comparison url.

Instruction count

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.4%	-0.4%	10
Improvements 🎉 (secondary)	-0.9%	-1.1%	4
All 😿🎉 (primary)	-0.4%	-0.4%	10

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.7%	3.1%	2
Improvements 🎉 (primary)	-1.0%	-1.0%	1
Improvements 🎉 (secondary)	-1.4%	-1.4%	2
All 😿🎉 (primary)	-1.0%	-1.0%	1

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

…rister Remove the source archive functionality of ArchiveWriter We now build archives through strictly additive means rather than taking an existing archive and potentially substracting parts. This is simpler and makes it easier to swap out the archive writer in rust-lang#97485.

Remove the source archive functionality of ArchiveWriter We now build archives through strictly additive means rather than taking an existing archive and potentially substracting parts. This is simpler and makes it easier to swap out the archive writer in rust-lang/rust#97485.

bors · 2022-06-26T14:46:24Z

☔ The latest upstream changes (presumably #98518) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-11-29T04:20:17Z

💔 Test failed - checks-actions

bjorn3 · 2022-11-29T11:10:53Z

That test first creates a libfoo.a archive and then attempts to link to it from a staticlib crate that is called foo too, overwriting libfoo.a, which fails on Windows as libfoo.a is already memory mapped. Should we support this? Based on the commit message introducing it, it seems to have been meant as test for linking against empty staticlibs, not as test for overwriting a staticlib we link against: 2eacc72

bjorn3 · 2022-12-02T13:12:14Z

Should be fixed now.

@rustbot ready

wesleywiser · 2022-12-02T15:04:03Z

@bors r+

bors · 2022-12-02T15:04:06Z

📌 Commit e1edc13 has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2022-12-02T15:23:06Z

⌛ Testing commit e1edc13 with merge b9363f7cb25c6d003443ba3c2e62ce335d2e64bb...

bors · 2022-12-02T15:31:07Z

💔 Test failed - checks-actions

lqd · 2022-12-02T15:33:51Z

@bors retry "curl: (22) The requested URL returned error: 503"

bors · 2022-12-02T18:29:38Z

⌛ Testing commit e1edc13 with merge 0b8f0a6d9125cea25f3b53bacd97a6d81759773f...

bors · 2022-12-02T19:36:09Z

💔 Test failed - checks-actions

…t archive

bjorn3 · 2022-12-03T12:55:06Z

Forgot to unmap all input archives before persisting the output archive. Windows doesn't like replacing a file that is currently mapped.

@bors r=wesleywiser

bors · 2022-12-03T12:55:08Z

📌 Commit a99838a has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2022-12-03T15:07:42Z

⌛ Testing commit a99838a with merge cab4fd6...

bjorn3 · 2022-12-03T17:30:49Z

All test builders completed successfully. 🎉 Only waiting on the Linux and macOS dist builders to finish now.

bors · 2022-12-03T18:11:35Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing cab4fd6 to master...

rust-timer · 2022-12-03T19:32:00Z

Finished benchmarking commit (cab4fd6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.2%]	12
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.6%, -0.2%]	12

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.0%, 3.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-1.6%, -1.6%]	1
All ❌✅ (primary)	-	-	0

bjorn3 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-cranelift Things relevant to the [future] cranelift backend A-gcc Things relevant to the [future] GCC backend labels May 28, 2022

rust-highfive assigned wesleywiser May 28, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2022

bjorn3 mentioned this pull request Jun 14, 2022
Remove the source archive functionality of ArchiveWriter #98098
Merged

bjorn3 mentioned this pull request Jun 14, 2022
Use object instead of LLVM for reading bitcode from rlibs #98100
Merged

bjorn3 force-pushed the new_archive_writer branch from eac8f47 to 502f5beCompare June 24, 2022 15:21

This comment has been minimized.
Sign in to view

Write to temp file before renaming to the final name
e1edc13

wesleywiser approved these changes Dec 2, 2022
View reviewed changes

This comment has been minimized.
Sign in to view

Make sure all input archives are unmapped before persisting the outpu…
a99838a
…t archive

This was referenced Dec 3, 2022
[perf] don't use temporary files for archive builder #104191
Closed
Migrate codegen_ssa to diagnostics structs - [Part 3] #104543
Merged
Support Option and similar enums as type of static variable with linkage attribute #104799
Merged

tedinski mentioned this pull request Dec 3, 2022
Investigate changes to archive.rs model-checking/kani#1957
Closed

sagudev mentioned this pull request Jan 21, 2023
Builds on Windows with the Beta branch are broken servo/mozjs#334
Closed

jdm mentioned this pull request Jan 21, 2023
Windows builds fail to link C++ static library #107162
Closed

alexcrichton mentioned this pull request Jan 31, 2023
Regression 1.67.0: Static archives have different unix permissions than before #107495
Closed

zhassan-aws mentioned this pull request May 23, 2023
Switch to rustc's archive builder model-checking/kani#2459
Merged
4 tasks

Uh oh!

Uh oh!

Conversation

bjorn3 commented May 28, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented May 28, 2022

Uh oh!

bjorn3 commented May 28, 2022

Uh oh!

rust-timer commented May 28, 2022

Uh oh!

bors commented May 28, 2022

Uh oh!

bors commented May 28, 2022

Uh oh!

rust-timer commented May 28, 2022

Uh oh!

rust-timer commented May 28, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

bors commented Jun 26, 2022

Uh oh!

bors commented Nov 29, 2022

Uh oh!

This comment has been minimized.

bjorn3 commented Nov 29, 2022

Uh oh!

bjorn3 commented Dec 2, 2022

Uh oh!

wesleywiser commented Dec 2, 2022

Uh oh!

bors commented Dec 2, 2022

Uh oh!

bors commented Dec 2, 2022

Uh oh!

bors commented Dec 2, 2022

Uh oh!

lqd commented Dec 2, 2022

Uh oh!

This comment has been minimized.

bors commented Dec 2, 2022

Uh oh!

bors commented Dec 2, 2022

Uh oh!

This comment has been minimized.

bjorn3 commented Dec 3, 2022

Uh oh!

bors commented Dec 3, 2022

Uh oh!

bors commented Dec 3, 2022

Uh oh!

bjorn3 commented Dec 3, 2022

Uh oh!

bors commented Dec 3, 2022

Uh oh!

rust-timer commented Dec 3, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

bjorn3 commented May 28, 2022•
edited
Loading