Remove the source archive functionality of ArchiveWriter by bjorn3 · Pull Request #98098 · rust-lang/rust

bjorn3 · 2022-06-14T16:14:40Z

We now build archives through strictly additive means rather than taking an existing archive and potentially substracting parts. This is simpler and makes it easier to swap out the archive writer in #97485.

They only apply to the main source archive and their role can be fulfilled through the skip argument of add_archive too.

rust-highfive · 2022-06-14T16:14:43Z

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

Some changes occured to rustc_codegen_gcc

cc @antoyo

rust-highfive · 2022-06-14T16:14:44Z

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

bjorn3 · 2022-06-14T16:14:51Z

@bors try @rust-timer queue

rust-timer · 2022-06-14T16:14:53Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-14T16:15:00Z

⌛ Trying commit a0df21d127494fbe882058dd758e4584aba11c61 with merge dde83d14faf6a20c9da4f9a8f2e79c480cc99b31...

bjorn3 · 2022-06-14T16:26:49Z

Forgot to commit a change to cg_gcc.

@bors try @rust-timer queue

rust-timer · 2022-06-14T16:26:51Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-14T16:26:58Z

⌛ Trying commit 5a3ebc591652f4c49d36e37d8674e45874f06426 with merge 3113cc267866d900333eee92db6f39e681cb6760...

bors · 2022-06-14T17:56:15Z

☀️ Try build successful - checks-actions
Build commit: 3113cc267866d900333eee92db6f39e681cb6760 (3113cc267866d900333eee92db6f39e681cb6760)

rust-timer · 2022-06-14T17:56:16Z

Queued 3113cc267866d900333eee92db6f39e681cb6760 with parent 872503d, future comparison URL.

rust-timer · 2022-06-14T20:07:15Z

Finished benchmarking commit (3113cc267866d900333eee92db6f39e681cb6760): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-1.0%	-1.0%	1
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	7.3%	7.3%	1
Regressions 😿 (secondary)	2.5%	2.5%	1
Improvements 🎉 (primary)	-1.9%	-1.9%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.7%	7.3%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

michaelwoerister · 2022-06-16T08:54:31Z

Thanks, @bjorn3, looks good to me!

@bors r+

bors · 2022-06-16T08:54:32Z

📌 Commit 5a3ebc591652f4c49d36e37d8674e45874f06426 has been approved by michaelwoerister

bors · 2022-06-16T10:15:48Z

⌛ Testing commit 5a3ebc591652f4c49d36e37d8674e45874f06426 with merge 2c30a9e214c3c81727926088e45382bc8c918de3...

bors · 2022-06-16T10:54:32Z

💔 Test failed - checks-actions

bjorn3 · 2022-06-19T12:58:58Z

That seems to have fixed it. Doing one final run with all reverts removed and then I can remove the debug commit.

@bors try

bors · 2022-06-19T12:59:07Z

⌛ Trying commit bc36a08ea5184b5f93770271a3217817b78e9393 with merge 89977ebb6b9823d02a4b1c2b5a73840663cade92...

bors · 2022-06-19T14:22:55Z

☀️ Try build successful - checks-actions
Build commit: 89977ebb6b9823d02a4b1c2b5a73840663cade92 (89977ebb6b9823d02a4b1c2b5a73840663cade92)

bjorn3 · 2022-06-19T14:23:02Z

It is indeed fixed. Removed the debug commit. The change is in 7ff0df5

@rustbot ready

michaelwoerister · 2022-06-21T09:39:23Z

Thanks, @bjorn3! Looks good.

@bors r+

bors · 2022-06-21T09:39:25Z

📌 Commit 7643f82 has been approved by michaelwoerister

bors · 2022-06-21T16:25:00Z

⌛ Testing commit 7643f82 with merge dc80ca7...

bjorn3 · 2022-06-21T19:32:16Z

Looks like macOS CI got stuck. Should I ask bors to retry?

bors · 2022-06-21T19:34:26Z

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing dc80ca7 to master...

bjorn3 · 2022-06-21T19:42:56Z

Looks like I was just too impatient.

rust-timer · 2022-06-21T20:53:01Z

Finished benchmarking commit (dc80ca7): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.8%	-1.4%	2
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.4%	3.6%	2
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.0%	2.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.0%	-2.0%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

The updates required were related to the following changes: - Simplify memory ordering intrinsics - rust-lang/rust#97423 - once cell renamings - rust-lang/rust#98165 - Rename the ConstS::val field as kind - rust-lang/rust#97935 - Remove the source archive functionality of ArchiveWriter - rust-lang/rust#98098 - Use valtrees as the type-system representation for constant values - rust-lang/rust#96591

* Update toolchain to 2022-07-05 The updates required were related to the following changes: - Simplify memory ordering intrinsics - rust-lang/rust#97423 - once cell renamings - rust-lang/rust#98165 - Rename the ConstS::val field as kind - rust-lang/rust#97935 - Remove the source archive functionality of ArchiveWriter - rust-lang/rust#98098 - Use valtrees as the type-system representation for constant values - rust-lang/rust#96591 * Codegen unimplemented for unsupported constant slices See #1339 for more details. * Fix copyright check * Use codegen_option_span instead

…rister Remove the source archive functionality of ArchiveWriter We now build archives through strictly additive means rather than taking an existing archive and potentially substracting parts. This is simpler and makes it easier to swap out the archive writer in rust-lang#97485.

bjorn3 added 2 commits June 14, 2022 14:33

Inline ArchiveConfig struct into LlvmArchiveBuilder
70e084a

Remove src_files and remove_file
43929a8
They only apply to the main source archive and their role can be fulfilled through the skip argument of add_archive too.

bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 14, 2022

rust-highfive assigned michaelwoerister Jun 14, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 14, 2022

bjorn3 force-pushed the archive_refactor branch from a0df21d to 5a3ebc5Compare June 14, 2022 16:26

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 14, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2022

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 16, 2022

Small refactoring
7643f82

bjorn3 force-pushed the archive_refactor branch from 3bcc957 to bc36a08Compare June 19, 2022 12:58

bjorn3 force-pushed the archive_refactor branch from bc36a08 to 7643f82Compare June 19, 2022 14:22

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 21, 2022

bors merged commit dc80ca7 into rust-lang:masterJun 21, 2022

rustbot added this to the 1.63.0 milestone Jun 21, 2022

bjorn3 deleted the archive_refactor branch June 21, 2022 19:43

celinval mentioned this pull request Jul 6, 2022
Update toolchain to 2022-07-05 model-checking/kani#1340
Merged
4 tasks

matthiaskrgr mentioned this pull request Dec 7, 2023
ICE: ast lowering: no entry for node id: NodeId(26)#118697
Closed

levinwinter mentioned this pull request Jul 4, 2025
ICE: no entry for node id: NodeId(27)#143413
Closed

Uh oh!

Uh oh!

Conversation

bjorn3 commented Jun 14, 2022

Uh oh!

rust-highfive commented Jun 14, 2022

Uh oh!

rust-highfive commented Jun 14, 2022

Uh oh!

bjorn3 commented Jun 14, 2022

Uh oh!

rust-timer commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

bjorn3 commented Jun 14, 2022

Uh oh!

rust-timer commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

bors commented Jun 14, 2022

Uh oh!

rust-timer commented Jun 14, 2022

Uh oh!

rust-timer commented Jun 14, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

michaelwoerister commented Jun 16, 2022

Uh oh!

bors commented Jun 16, 2022

Uh oh!

bors commented Jun 16, 2022

Uh oh!

bors commented Jun 16, 2022

Uh oh!

bjorn3 commented Jun 19, 2022

Uh oh!

bors commented Jun 19, 2022

Uh oh!

bors commented Jun 19, 2022

Uh oh!

bjorn3 commented Jun 19, 2022

Uh oh!

michaelwoerister commented Jun 21, 2022

Uh oh!

bors commented Jun 21, 2022

Uh oh!

bors commented Jun 21, 2022

Uh oh!

bjorn3 commented Jun 21, 2022

Uh oh!

bors commented Jun 21, 2022

Uh oh!

bjorn3 commented Jun 21, 2022

Uh oh!

rust-timer commented Jun 21, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants