Skip to content

Rollup of 7 pull requests - #97496

Closed
GuillaumeGomez wants to merge 17 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup-sursx4z
Closed

Rollup of 7 pull requests#97496
GuillaumeGomez wants to merge 17 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup-sursx4z

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

JohnTitorand others added 17 commits May 12, 2022 00:34
…zer]` attribute. Add tests for embedding pretty printers and update documentation.
Ensure all error checking for `#[debugger_visualizer]` is done up front and not when the `debugger_visualizer` query is run.
Clean up potential ODR violations when embedding pretty printers into the `__rustc_debug_gdb_scripts_section__` section.
Respond to PR comments and update documentation.
…rrors,oli-obk
Add regression test for rust-lang#96395Closesrust-lang#96395
This repeats "fixed" and "ICE", see rust-lang/glacier#1243 (comment)
I think it's good to add a test before regressing again.
r? `@compiler-errors` for quick reviiew
cc `@oli-obk` you might want to check as you're familiar with MIR
…idtwco
Add validation layer for Derefer
_Follow up work to rust-lang#96549rust-lang#96116rust-lang#95857 #95649_
This adds validation for Derefer making sure it is always the first projection.
r? rust-lang/mir-opt
…ichaelwoerister
Add support for embedding pretty printers via `#[debugger_visualizer]` attribute
Initial support for [RFC 3191](rust-lang/rfcs#3191) in PR rust-lang#91779 was scoped to supporting embedding NatVis files using a new attribute. This PR implements the pretty printer support as stated in the RFC mentioned above.
This change includes embedding pretty printers in the `.debug_gdb_scripts` just as the pretty printers for rustc are embedded today. Also added additional tests for embedded pretty printers. Additionally cleaned up error checking so all error checking is done up front regardless of the current target.
RFC: rust-lang/rfcs#3191
…Dylan-DPC
library/std: Bump compiler_builtins
Some neat changes include faster float conversions & fixes for AVR 🙂
(note that's it's my first time upgrading `compiler_builtins`, so I'm not 100% sure if bumping `library/std/Cargo.toml` is enough; certainly seems to be so, though.)
…-errors
Remove FIXME on `ExtCtxt::fn_decl()`
`ExtCtxt::fn_decl()` is used like `self.fn_decl(..)` or `self.cx.fn_decl(..)`, coverting it to an assoc fn, for example, makes it inconvenience (e.g. `self.cx.fn_decl(..)` would be longer to represent). Given that, it doesn't seem a "FIXME" thing and unused `self` is okay, I think.
…er-errors
Make some tests check-pass
This touches the tests related to lint, parser, and importing, all of them should be fine with `check-pass`.
r? `@compiler-errors`
ptr::invalid is not equivalent to a int2ptr cast
I just realized I forgot to update these docs when adding `from_exposed_addr`.
Right now the docs say `invalid` and `from_exposed_addr` are both equivalent to a cast, and that is clearly not what we want.
Cc `@Gankra`
@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 28, 2022
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=7 rollup=never

@bors

bors commented May 28, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit bd20c1d has been approved by GuillaumeGomez

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 28, 2022
@bors

bors commented May 28, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit bd20c1d with merge d4aadada4c2ad6b5133e88312b2bbde12f9d594d...

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-various failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
test [mir-opt] src/test/mir-opt/uniform_array_move_out.rs ... ok
failures:
---- [mir-opt] src/test/mir-opt/derefer_inline_test.rs stdout ----
25 bb1: {
26 StorageLive(_5); // scope 0 at $DIR/derefer_inline_test.rs:8:5: 8:12
27 _5 = ShallowInitBox(move _4, std::boxed::Box<i32>); // scope 0 at $DIR/derefer_inline_test.rs:8:5: 8:12
Some tests failed in compiletest suite=mir-opt mode=mir-opt host=x86_64-unknown-linux-gnu target=wasm32-unknown-unknown
- (*_5) = f() -> [return: bb2, unwind: bb5]; // scope 0 at $DIR/derefer_inline_test.rs:8:9: 8:12
+ (*_5) = f() -> bb2; // scope 0 at $DIR/derefer_inline_test.rs:8:9: 8:12
29 // mir::Constant
30 // + span: $DIR/derefer_inline_test.rs:8:9: 8:10
31 // + literal: Const { ty: fn() -> Box<i32> {f}, val: Value(Scalar(<ZST>)) }
38 39 bb3: {
39 bb3: {
40 StorageDead(_5); // scope 0 at $DIR/derefer_inline_test.rs:8:11: 8:12
- drop(_1) -> [return: bb4, unwind: bb6]; // scope 0 at $DIR/derefer_inline_test.rs:8:12: 8:13
+ drop(_1) -> bb4; // scope 0 at $DIR/derefer_inline_test.rs:8:12: 8:13
43 44 bb4: {
48 }
48 }
49 50 bb5 (cleanup): {
- goto -> bb8; // scope 0 at $DIR/derefer_inline_test.rs:8:11: 8:12
- - - bb6 (cleanup): {
55 resume; // scope 0 at $DIR/derefer_inline_test.rs:7:1: 9:2
- - - bb7 (cleanup): {
- _6 = alloc::alloc::box_free::<Box<i32>, std::alloc::Global>(move (_5.0: std::ptr::Unique<std::boxed::Box<i32>>), move (_5.1: std::alloc::Global)) -> bb6; // scope 0 at $DIR/derefer_inline_test.rs:8:11: 8:12
- // mir::Constant
- // + span: $DIR/derefer_inline_test.rs:8:11: 8:12
- // + literal: Const { ty: unsafe fn(Unique<Box<i32>>, std::alloc::Global) {alloc::alloc::box_free::<Box<i32>, std::alloc::Global>}, val: Value(Scalar(<ZST>)) }
- - - bb8 (cleanup): {
- goto -> bb7; // scope 0 at $DIR/derefer_inline_test.rs:8:11: 8:12
68 }
69 thread '[mir-opt] src/test/mir-opt/derefer_inline_test.rs' panicked at 'Actual MIR output differs from expected MIR output /checkout/src/test/mir-opt/derefer_inline_test.main.Derefer.diff', src/tools/compiletest/src/runtest.rs:3420:25
failures:
[mir-opt] src/test/mir-opt/derefer_inline_test.rs

@bors

bors commented May 28, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 28, 2022
@GuillaumeGomez
GuillaumeGomez deleted the rollup-sursx4z branch May 28, 2022 23:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@GuillaumeGomez@bors@rust-log-analyzer@rustbot@JohnTitor@ridwanabdillahi@Patryk27@ouz-a@RalfJung