Skip to content

Rollup of 3 pull requests - #98131

Merged
bors merged 7 commits into
rust-lang:masterfrom
JohnTitor:rollup-c17vjdy
Jun 15, 2022
Merged

Rollup of 3 pull requests#98131
bors merged 7 commits into
rust-lang:masterfrom
JohnTitor:rollup-c17vjdy

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

cjgillotand others added 7 commits June 12, 2022 00:16
Implement stabilization of [I/O safety], aka `#[feature(io_safety)]`.
Fixesrust-lang#87074.
[I/O safety]: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md
…o-safety, r=joshtriplett
Implement stabilization of `#[feature(io_safety)]`.
Implement stabilization of [I/O safety], aka `#[feature(io_safety)]`.
Fixesrust-lang#87074.
[I/O safety]: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md
Make `ExprKind::Closure` a struct variant.
Simple refactor since we both need it to introduce additional fields in `ExprKind::Closure`.
r? ``@Aaron1011``
…compiler-errors
Remove `rustc_deprecated` diagnostics
Follow-up on rust-lang#95960. The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust.
``@rustbot`` label +A-diagnostics
r? ``@compiler-errors``
@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 15, 2022
@JohnTitor

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=3 rollup=never

@bors

bors commented Jun 15, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit b1e5472 has been approved by JohnTitor

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 15, 2022
@bors

bors commented Jun 15, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b1e5472 with merge a4cec97...

@bors

bors commented Jun 15, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing a4cec97 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 15, 2022
@bors
bors merged commit a4cec97 into rust-lang:masterJun 15, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 15, 2022
@JohnTitor
JohnTitor deleted the rollup-c17vjdy branch June 15, 2022 14:00
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a4cec97): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1maxcount2
Regressions 😿
(primary)
N/AN/A0
Regressions 😿
(secondary)
0.3%0.3%1
Improvements 🎉
(primary)
N/AN/A0
Improvements 🎉
(secondary)
N/AN/A0
All 😿🎉 (primary)N/AN/A0

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: mixed results
mean1maxcount2
Regressions 😿
(primary)
0.7%0.7%1
Regressions 😿
(secondary)
2.1%2.1%1
Improvements 🎉
(primary)
N/AN/A0
Improvements 🎉
(secondary)
-3.5%-3.8%2
All 😿🎉 (primary)0.7%0.7%1

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1maxcount2
Regressions 😿
(primary)
N/AN/A0
Regressions 😿
(secondary)
N/AN/A0
Improvements 🎉
(primary)
N/AN/A0
Improvements 🎉
(secondary)
-2.1%-2.1%1
All 😿🎉 (primary)N/AN/A0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change23

  2. number of relevant changes23

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@JohnTitor@bors@rust-timer@rustbot@cjgillot@sunfishcode@jhpratt