Skip to content

Improve lifetime arguments are not allowed on error message - #98268

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:disallowed-generics-better
Jun 20, 2022
Merged

Improve lifetime arguments are not allowed on error message#98268
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:disallowed-generics-better

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Actually mention what thing we're improperly trying to add lifetime generics to.

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 20, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
@lcnr

lcnr commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 2762d62 has been approved by lcnr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022
@JohnTitorJohnTitor mentioned this pull request Jun 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2022
Rollup of 5 pull requests
Successful merges:
- rust-lang#98183 (Fix pretty printing of empty bound lists in where-clause)
- rust-lang#98268 (Improve `lifetime arguments are not allowed on` error message)
- rust-lang#98273 (Fix minor documentation typo)
- rust-lang#98274 (Minor improvements on error for `Self` type in items that don't allow it)
- rust-lang#98281 (Fix typo in `HashMap::drain` docs)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e635704 into rust-lang:masterJun 20, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 20, 2022
@compiler-errors
compiler-errors deleted the disallowed-generics-better branch August 11, 2023 19:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors@rust-highfive@lcnr@bors@rustbot