Skip to content

Fix typo in HashMap::drain docs - #98281

Merged
bors merged 1 commit into
rust-lang:masterfrom
Noratrieb:map-drain-typo
Jun 20, 2022
Merged

Fix typo in HashMap::drain docs#98281
bors merged 1 commit into
rust-lang:masterfrom
Noratrieb:map-drain-typo

Conversation

@Noratrieb

@NoratriebNoratrieb commented Jun 20, 2022•
edited
Loading

Copy link
Copy Markdown
Member

It's a map, not a vector.

Fixes#98275.

@Noratrieb
Fix typo in HashMap::drain docs
2ead0d7
It's a map, not a vector.
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 20, 2022
@rust-highfive

rust-highfive commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
JohnTitor
JohnTitor approved these changes Jun 20, 2022
View reviewed changes

@JohnTitorJohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor

JohnTitor commented Jun 20, 2022

Copy link
Copy Markdown
Member

r? @JohnTitor@bors r+ rollup

@bors

bors commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 2ead0d7 has been approved by JohnTitor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022
@JohnTitorJohnTitor mentioned this pull request Jun 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2022
@bors
Auto merge ofrust-lang#98284- JohnTitor:rollup-7lbs143, r=JohnTitor
4104596
Rollup of 5 pull requests
Successful merges:
- rust-lang#98183 (Fix pretty printing of empty bound lists in where-clause)
- rust-lang#98268 (Improve `lifetime arguments are not allowed on` error message)
- rust-lang#98273 (Fix minor documentation typo)
- rust-lang#98274 (Minor improvements on error for `Self` type in items that don't allow it)
- rust-lang#98281 (Fix typo in `HashMap::drain` docs)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 66dbc3f into rust-lang:masterJun 20, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 20, 2022
@Noratrieb
Noratrieb deleted the map-drain-typo branch June 20, 2022 11:55
@NoratriebNoratrieb mentioned this pull request Sep 2, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@JohnTitorJohnTitor

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

Incorrect doc for drain fn on hahsmap

6 participants

@Noratrieb@rust-highfive@JohnTitor@bors@Mark-Simulacrum@rustbot