Skip to content

Rebase LLVM submodule - #98285

Merged
bors merged 1 commit into
rust-lang:masterfrom
nikic:update-llvm-5
Jun 27, 2022
Merged

Rebase LLVM submodule#98285
bors merged 1 commit into
rust-lang:masterfrom
nikic:update-llvm-5

Conversation

@nikic

@nikicnikic commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

This is a rebase of our LLVM fork onto LLVM 14.0.5, which is intended to be the last release of the 14.x series. Additionally:

@rust-highfive

rust-highfive commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
@nikic

nikic commented Jun 20, 2022

Copy link
Copy Markdown
ContributorAuthor

r? @cuviper

@cuviper

cuviper commented Jun 21, 2022

Copy link
Copy Markdown
Member

@tstellar tells me there will be a 14.0.6 this week, so I suppose we should hold for that. Maybe your additional cherry-pick can sneak in there as well?

@nikic

nikic commented Jun 21, 2022

Copy link
Copy Markdown
ContributorAuthor

I don't think I can force-push rust-lang/llvm-project, so I'd probably keep this branch and merge additional commits if needed. I opened llvm/llvm-project#56150 for the upstream cherry-pick though.

@nikic

nikic commented Jun 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Okay, looks like the 14.0.6 release is a very small one (https://discourse.llvm.org/t/llvm-14-0-6-release/63431), that fixes an AVR regression in clang. I've merged the three new commits.

@cuviper

cuviper commented Jun 25, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup=never

@bors

bors commented Jun 25, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 6e6b3ea has been approved by cuviper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2022
@bors

bors commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6e6b3ea with merge bd2e51a...

@slanternsslanterns mentioned this pull request Jun 27, 2022
Merged
@bors

bors commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing bd2e51a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2022
@bors
bors merged commit bd2e51a into rust-lang:masterJun 27, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jun 27, 2022
@oToToToToToT mentioned this pull request Jun 27, 2022
Closed
@rust-timer

rust-timer commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (bd2e51a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		2.8%2.8%1
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		-2.0%-2.0%1
All 😿🎉 (primary)N/AN/A0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩

  2. number of relevant changes↩

@AmanieuAmanieu mentioned this pull request Jul 8, 2022
Merged
Amanieu added a commit to Amanieu/rust that referenced this pull request Jul 12, 2022
@Amanieu
Add test forrust-lang#96797
5566099
This was fixed in LLVM which was updated in rust-lang#98285.
https://reviews.llvm.org/D127751Fixesrust-lang#96797
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 18, 2022
@Dylan-DPC
Rollup merge ofrust-lang#99059- Amanieu:fix-96797, r=Mark-Simulacrum
5e58b1b
Add test for rust-lang#96797
This was fixed in LLVM which was updated in rust-lang#98285.
https://reviews.llvm.org/D127751Fixesrust-lang#96797
Amanieu added a commit to Amanieu/rust that referenced this pull request Jul 21, 2022
@Amanieu
Add test forrust-lang#96797
4423341
This was fixed in LLVM which was updated in rust-lang#98285.
https://reviews.llvm.org/D127751Fixesrust-lang#96797
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2022
@bors
Auto merge ofrust-lang#99059- Amanieu:fix-96797, r=Mark-Simulacrum
1673f14
Add test for rust-lang#96797
This was fixed in LLVM which was updated in rust-lang#98285.
https://reviews.llvm.org/D127751Fixesrust-lang#96797
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuvipercuviper

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nikic@rust-highfive@cuviper@bors@rust-timer@Mark-Simulacrum@rustbot