Update llvm-project by Patryk27 · Pull Request #98567 · rust-lang/rust

Patryk27 · 2022-06-27T06:25:34Z

Closes#98167 🙂

rust-highfive · 2022-06-27T06:25:37Z

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2022-06-27T06:25:38Z

⚠️Warning⚠️

These commits modify submodules.

slanterns · 2022-06-27T06:37:11Z

duplicate with #98285 ?

Patryk27 · 2022-06-27T06:39:11Z

Kinda, that one doesn't contain the recent commit from yesterday that fixes the AVR bug I've linked 😅 (since it uses llvm-project from two days ago)

I guess I'll just rebase my PR after #98285 gets merged.

bors · 2022-06-27T09:09:19Z

☔ The latest upstream changes (presumably #98285) made this pull request unmergeable. Please resolve the merge conflicts.

Patryk27 · 2022-06-27T09:17:02Z

Ready!

cuviper · 2022-06-27T17:13:32Z

@bors r+

bors · 2022-06-27T17:13:33Z

📌 Commit dafe7a17847dfb287430155ab0c6be84da0b556b has been approved by cuviper

nikic · 2022-07-05T14:13:10Z

As this hasn't been merged yet, would you mind updating this PR to the latest commit? I've pushed two more backports.

Patryk27 · 2022-07-05T14:16:28Z

Sure, I’ll take a look in two hours or so 🙂

Patryk27 · 2022-07-05T16:00:03Z

kk, done!

nikic · 2022-07-05T16:05:08Z

Thanks!

@bors r+ rollup=never

bors · 2022-07-05T16:05:10Z

📌 Commit d61e4a4 has been approved by nikic

bors · 2022-07-06T12:29:43Z

⌛ Testing commit d61e4a4 with merge 0aef720...

bors · 2022-07-06T15:10:31Z

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 0aef720 to master...

rust-timer · 2022-07-06T16:51:17Z

Finished benchmarking commit (0aef720): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	0.7%	0.9%	8
Regressions 😿 (secondary)	1.5%	2.4%	10
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-1.1%	-1.1%	1
All 😿🎉 (primary)	0.7%	0.9%	8

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.1%	2.1%	1
Improvements 🎉 (primary)	-1.0%	-1.0%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-1.0%	-1.0%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.9%	4.0%	9
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

nikic · 2022-07-06T16:54:20Z

Perf result seems to be noise, it seems to be the opposite of the results on the previous commit: https://perf.rust-lang.org/compare.html?start=f342bea9d19f14616c6559312552e6d0ee529cfd&end=5b8cf49c51833ee5d27ae2e8e179337dbb9f14d7&stat=instructions:u

nikic · 2022-07-06T16:59:39Z

Beta nominating as fix for the P-critical miscompile in #98568. The update also includes a fix for an AVR-only miscompile (#98167), as well as an assertion failure (#98076).

Submodule diff: rust-lang/llvm-project@d1ddc34...8b6b501

workingjubilee · 2022-07-06T18:40:04Z

Thank you, @Patryk27 and @nikic!

apiraino · 2022-07-07T14:45:36Z

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

Mark-Simulacrum · 2022-07-09T21:15:05Z

@nikic is it a problem if we backport by rolling forward to the latest commit here on beta? (rust-lang/llvm-project@c9e2e89...8b6b501)

Otherwise can create a targeted backport with a helper branch, but want to make sure there's no accidental mistakes missing a dependency on a previous commit here.

nikic · 2022-07-09T21:27:06Z

@Mark-Simulacrum I think we need a separate backport branch here, because the LLVM fork has been rebased in the meantime, and I'm not confident that it will build on beta (specifically FreeBSD). And no, I don't think there are any relevant dependency commits.

Mark-Simulacrum · 2022-07-09T22:20:40Z

OK, sounds good. I'll look into doing that.

This cherry picks: * c9676870a8f378940ec446c4184254f361feabe6 * f14a034634ac7ddc314008e39d62af6ceae0166a * 3317cfea1b72c0861c9e4e9f5eba5713fd19e7f7 * 8b6b5014fdad3a750f7242a6bfdcad83619498d4

Mark-Simulacrum · 2022-07-09T22:26:13Z

Included in #99098, branch rustc/14.0-2022-07-09.

…ulacrum [beta] backport rollup * Return a FxIndexSet in is_late_bound query. rust-lang#98959 * rustdoc: filter '_ lifetimes from ty::PolyTraitRef rust-lang#98727 * don't succeed evaluate_obligation query if new opaque types were registered rust-lang#98614 * Update llvm-project rust-lang#98567 There's a few more as-yet-unapproved/unmerged PRs that'll land later, but creating a partial rollup for now so that we can include at least some PRs in the first crater run. r? `@Mark-Simulacrum`

Mark-Simulacrum · 2022-07-12T12:48:52Z

Dropping regression label, agree that the results are likely noise. See #98925 (comment) for some graphs.

Newest rustc contains an important bugfix to AVR's code generator (rust-lang/rust#98567). Ref: Rahix/avr-hal-template#9

rust-highfive assigned cuviper Jun 27, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2022

Patryk27 force-pushed the update-llvm branch from 2b8554b to dafe7a1Compare June 27, 2022 09:16

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2022

Update llvm-project
d61e4a4

Patryk27 force-pushed the update-llvm branch from dafe7a1 to d61e4a4Compare July 5, 2022 15:59

RalfJung mentioned this pull request Jul 6, 2022
Rollup of 5 pull requests #98970
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2022

bors merged commit 0aef720 into rust-lang:masterJul 6, 2022

rustbot added this to the 1.64.0 milestone Jul 6, 2022

Patryk27 deleted the update-llvm branch July 6, 2022 15:18

rustbot added the perf-regression Performance regression. label Jul 6, 2022

nikic added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 6, 2022

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 7, 2022

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 7, 2022

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 9, 2022

Mark-Simulacrum modified the milestones: 1.64.0, 1.63.0 Jul 9, 2022

Mark-Simulacrum mentioned this pull request Jul 9, 2022
[beta] backport rollup #99098
Merged

Mark-Simulacrum removed the perf-regression Performance regression. label Jul 12, 2022

pnkfelix mentioned this pull request Jul 28, 2022
Wrong optimization #98568
Closed

Rahix added a commit to Rahix/avr-hal that referenced this pull request Jul 28, 2022
Upgrade toolchain
f6c8b31
Newest rustc contains an important bugfix to AVR's code generator (rust-lang/rust#98567). Ref: Rahix/avr-hal-template#9

Uh oh!

Uh oh!

Conversation

Patryk27 commented Jun 27, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 27, 2022

Uh oh!

rust-highfive commented Jun 27, 2022

Uh oh!

slanterns commented Jun 27, 2022

Uh oh!

Patryk27 commented Jun 27, 2022

Uh oh!

bors commented Jun 27, 2022

Uh oh!

Patryk27 commented Jun 27, 2022

Uh oh!

cuviper commented Jun 27, 2022

Uh oh!

bors commented Jun 27, 2022

Uh oh!

nikic commented Jul 5, 2022

Uh oh!

Patryk27 commented Jul 5, 2022

Uh oh!

Patryk27 commented Jul 5, 2022

Uh oh!

nikic commented Jul 5, 2022

Uh oh!

bors commented Jul 5, 2022

Uh oh!

bors commented Jul 6, 2022

Uh oh!

bors commented Jul 6, 2022

Uh oh!

rust-timer commented Jul 6, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

nikic commented Jul 6, 2022

Uh oh!

nikic commented Jul 6, 2022

Uh oh!

workingjubilee commented Jul 6, 2022

Uh oh!

apiraino commented Jul 7, 2022

Uh oh!

Mark-Simulacrum commented Jul 9, 2022

Uh oh!

nikic commented Jul 9, 2022

Uh oh!

Mark-Simulacrum commented Jul 9, 2022

Uh oh!

Mark-Simulacrum commented Jul 9, 2022

Uh oh!

Mark-Simulacrum commented Jul 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Patryk27 commented Jun 27, 2022•
edited
Loading